Skip to content

drm/dp: Move drm_dp_link helpers to Tegra DRM

Thierry Reding dri-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 6 repliesIn review
  2. v221 patches 6 repliesSuperseded
  3. v121 patches 12 repliesSuperseded

Changes in v3 from the cover letter

- drop drm_dp_aux_rd_interval() helper patch; this turned out to be incomplete and fixing it made it useless over existing helpers
- add Reviewed-by from Lyude
- address review comments

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13drm/dp: Sort includes alphabeticallyinclude/drm/drm_dp_helper.h+2 -20 replies
2/13drm/dp: Remove a gratuituous blank linedrivers/gpu/drm/drm_dp_helper.c+0 -10 replies
3/13drm/dp: Add drm_dp_fast_training_cap() helperinclude/drm/drm_dp_helper.h+7 -00 replies
4/13drm/dp: Add drm_dp_channel_coding_supported() helperinclude/drm/drm_dp_helper.h+7 -00 replies
5/13drm/dp: Add drm_dp_alternate_scrambler_reset_cap() helperinclude/drm/drm_dp_helper.h+7 -00 replies
6/13drm/dp: Do not busy-loop during link trainingdrivers/gpu/drm/drm_dp_helper.c+18 -121 reply
7/13drm/dp: Add helper to get post-cursor adjustmentsdrivers/gpu/drm/drm_dp_helper.c include/drm/drm_dp_helper.h+20 -00 replies
8/13drm/bridge: analogix-anx78xx: Avoid drm_dp_link helpersdrivers/gpu/drm/bridge/analogix-anx78xx.c+42 -153 replies
9/13drm/bridge: tc358767: Avoid drm_dp_link helpersdrivers/gpu/drm/bridge/tc358767.c+41 -221 reply
10/13drm/bridge: tc358767: Use DP nomenclaturedrivers/gpu/drm/bridge/tc358767.c+1 -10 replies
11/13drm/msm: edp: Avoid drm_dp_link helpersdrivers/gpu/drm/msm/edp/edp_ctrl.c+49 -211 reply
12/13drm/rockchip: Avoid drm_dp_link helpersdrivers/gpu/drm/rockchip/cdn-dp-core.c drivers/gpu/drm/rockchip/cdn-dp-core.h drivers/gpu/drm/rockchip/cdn-dp-reg.c+17 -171 reply
13/13drm/tegra: Move drm_dp_link helpers to Tegra DRMdrivers/gpu/drm/drm_dp_helper.c drivers/gpu/drm/tegra/Makefile drivers/gpu/drm/tegra/dp.c +4 more+162 -1441 reply

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchLyude PaulPhilipp ZabelAndrzej HajdaDaniel Vetter
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b R-b
8/13R-b R-b
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/13] drm/dp: Move drm_dp_link helpers to Tegra DRM

From: Thierry Reding <[email protected]>

Hi,

Following up on the discussion about the usefulness of the drm_dp_link helpers, here's a new series that adds a couple of new DPCD parser functions and then pushes the drm_dp_link helpers down into drivers. For most drivers this was pretty easy to do since they didn't heavily rely on the struct drm_dp_link. I decided to move the drm_dp_link helpers to the Tegra driver because they are more heavily used there and I have a subsequent series that adds support for DisplayPort on various Tegra boards based on those helpers.

The plan is to merge this series into drm-misc once reviewed so that I can rebase my Tegra DP support patches on that, hopefully in time for v5.5.

I don't have access to the bridges, Rockchip or MSM hardware, so those drivers are only build-tested. Since this series really only replaces variables, I don't think there's a high risk of breaking anything.

Changes in v3:
- drop drm_dp_aux_rd_interval() helper patch; this turned out to be incomplete and fixing it made it useless over existing helpers
- add Reviewed-by from Lyude
- address review comments

Thierry

Thierry Reding (13):
drm/dp: Sort includes alphabetically
drm/dp: Remove a gratuituous blank line
drm/dp: Add drm_dp_fast_training_cap() helper drm/dp: Add drm_dp_channel_coding_supported() helper drm/dp: Add drm_dp_alternate_scrambler_reset_cap() helper drm/dp: Do not busy-loop during link training drm/dp: Add helper to get post-cursor adjustments drm/bridge: analogix-anx78xx: Avoid drm_dp_link helpers drm/bridge: tc358767: Avoid drm_dp_link helpers drm/bridge: tc358767: Use DP nomenclature drm/msm: edp: Avoid drm_dp_link helpers drm/rockchip: Avoid drm_dp_link helpers drm/tegra: Move drm_dp_link helpers to Tegra DRM

 drivers/gpu/drm/bridge/analogix-anx78xx.c |  57 ++++++--
 drivers/gpu/drm/bridge/tc358767.c         |  65 ++++++---
 drivers/gpu/drm/drm_dp_helper.c           | 169 ++++------------------
 drivers/gpu/drm/msm/edp/edp_ctrl.c        |  70 ++++++---
 drivers/gpu/drm/rockchip/cdn-dp-core.c    |  12 +-
 drivers/gpu/drm/rockchip/cdn-dp-core.h    |   3 +-
 drivers/gpu/drm/rockchip/cdn-dp-reg.c     |  19 ++-
 drivers/gpu/drm/tegra/Makefile            |   1 +
 drivers/gpu/drm/tegra/dp.c                | 133 +++++++++++++++++
 drivers/gpu/drm/tegra/dp.h                |  26 ++++
 drivers/gpu/drm/tegra/dpaux.c             |   1 +
 drivers/gpu/drm/tegra/sor.c               |   1 +
 include/drm/drm_dp_helper.h               |  51 ++++---
 13 files changed, 373 insertions(+), 235 deletions(-)
 create mode 100644 drivers/gpu/drm/tegra/dp.c
 create mode 100644 drivers/gpu/drm/tegra/dp.h
Signature · 6 lines
2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel