Skip to content

media: imx: Create media links in bound notifiers

Steve Longerbeam linux-media 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest22 patches 5 repliesIn review
  2. v523 patches 6 repliesSuperseded
  3. v417 patches 20 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v3 posting 2/217 patches6 repliesSuperseded
v3 posting 1/217 patches1 replySuperseded
v223 patches14 repliesSuperseded
v122 patches12 repliesSuperseded

Changes in v6 from the cover letter

- Renamed v4l2_subdev_get_fwnode_pad_default() to v4l2_subdev_get_fwnode_pad_1_to_1().
- Instead of verifying the endpoint itself is owned by the subdevice, it's sufficient and more efficient to verify the endpoint's port parent is the subdevice, in v4l2_subdev_get_fwnode_pad_1_to_1(). Suggested by Sakari.
- Dropped patch "media: entity: Modify default behavior of media_entity_get_fwnode_pad" again. It's not strictly needed for this patchset and can be revisited later.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22media: entity: Pass entity to get_fwnode_pad operationdrivers/media/mc/mc-entity.c include/media/media-entity.h+3 -20 replies
2/22media: v4l2-subdev: add v4l2_subdev_get_fwnode_pad_1_to_1drivers/media/v4l2-core/v4l2-subdev.c include/media/v4l2-subdev.h+39 -00 replies
3/22media: v4l2-mc: add v4l2_create_fwnode_links helpersdrivers/media/v4l2-core/v4l2-mc.c include/media/v4l2-mc.h+143 -00 replies
4/22media: video-mux: Parse information from firmware without using callbacksdrivers/media/platform/video-mux.c+46 -240 replies
5/22media: imx: Parse information from firmware without using callbacksdrivers/staging/media/imx/imx-media-csi.c drivers/staging/media/imx/imx6-mipi-csi2.c drivers/staging/media/imx/imx7-media-csi.c +1 more+192 -1000 replies
6/22Revert "media: v4l2-fwnode: Add a convenience function for registering subdevs with notifiers"drivers/media/v4l2-core/v4l2-fwnode.c include/media/v4l2-fwnode.h+0 -1000 replies
7/22media: imx: csi: Implement get_fwnode_pad opdrivers/staging/media/imx/imx-media-csi.c+23 -00 replies
8/22media: video-mux: Implement get_fwnode_pad opdrivers/media/platform/video-mux.c+1 -00 replies
9/22media: imx: mipi csi-2: Implement get_fwnode_pad opdrivers/staging/media/imx/imx6-mipi-csi2.c+1 -00 replies
10/22media: imx: imx7-mipi-csis: Implement get_fwnode_pad opdrivers/staging/media/imx/imx7-mipi-csis.c+1 -01 reply
11/22media: imx: imx7-media-csi: Implement get_fwnode_pad opdrivers/staging/media/imx/imx7-media-csi.c+1 -01 reply
12/22media: video-mux: Create media links in bound notifierdrivers/media/platform/video-mux.c+22 -00 replies
13/22media: imx: mipi csi-2: Create media links in bound notifierdrivers/staging/media/imx/imx6-mipi-csi2.c+22 -00 replies
14/22media: imx7: mipi csis: Create media links in bound notifierdrivers/staging/media/imx/imx7-mipi-csis.c+23 -01 reply
15/22media: imx7: csi: Create media links in bound notifierdrivers/staging/media/imx/imx7-media-csi.c+22 -00 replies
16/22media: imx: csi: Create media links in bound notifierdrivers/staging/media/imx/imx-media-csi.c+21 -00 replies
17/22media: imx7: csi: Remove imx7_csi_get_upstream_endpoint()drivers/staging/media/imx/imx7-media-csi.c+12 -651 reply
18/22media: imx5/6/7: csi: Mark a bound video mux as a CSI muxdrivers/staging/media/imx/imx-media-csi.c drivers/staging/media/imx/imx-media.h drivers/staging/media/imx/imx7-media-csi.c+35 -181 reply
19/22media: imx: csi: Lookup upstream endpoint with imx_media_get_pad_fwnodedrivers/staging/media/imx/imx-media-csi.c drivers/staging/media/imx/imx-media-utils.c drivers/staging/media/imx/imx-media.h+40 -160 replies
20/22media: imx: Create missing links from CSI-2 receiverdrivers/staging/media/imx/imx-media-dev-common.c drivers/staging/media/imx/imx-media-of.c drivers/staging/media/imx/imx-media.h+17 -1470 replies
21/22media: imx: silence a couple debug messagesdrivers/staging/media/imx/imx-media-dev-common.c drivers/staging/media/imx/imx-media-dev.c drivers/staging/media/imx/imx-media-internal-sd.c+7 -50 replies
22/22media: imx: TODO: Remove media link creation todosdrivers/staging/media/imx/TODO+0 -290 replies

Reviews trailers per patch

10 of 22 patches have a Reviewed-by or Acked-by.

PatchLaurent PinchartRui Miguel Silva
1/22R-b
2/22
3/22
4/22
5/22
6/22
7/22R-b
8/22
9/22
10/22A-b
11/22A-b
12/22
13/22
14/22A-b
15/22R-b
16/22
17/22A-b
18/22A-b
19/22
20/22R-b
21/22R-b
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/22] media: imx: Create media links in bound notifiers

Move media link creation into the notifier bound callbacks in the set of subdevices required by imx (imx5/6/7 CSI, imx6/7 MIPI CSI-2 receivers, and video-mux).

Rui, Laurent:

AFAICT the i.MX7 CSI can only ever connect to a CSI mux, which really makes the function imx7_csi_get_upstream_endpoint() unnecessary. See patches 17/22 and 18/22, and let me know if that makes sense.

History:

v6:
- Renamed v4l2_subdev_get_fwnode_pad_default() to v4l2_subdev_get_fwnode_pad_1_to_1().
- Instead of verifying the endpoint itself is owned by the subdevice, it's sufficient and more efficient to verify the endpoint's port parent is the subdevice, in v4l2_subdev_get_fwnode_pad_1_to_1(). Suggested by Sakari.
- Dropped patch "media: entity: Modify default behavior of media_entity_get_fwnode_pad" again. It's not strictly needed for this patchset and can be revisited later.

v5:
- Revived patch "media: entity: Modify default behavior of media_entity_get_fwnode_pad" from v2.
- Added a v4l2_subdev_get_fwnode_pad_default, which can be used as a subdev's .get_fwnode_pad() operation if the subdev maps fwnode port id's and pad indexes 1:1. Used by video-mux, imx6/7 MIPI CSI-2 receivers, and imx7 CSI.
- Exported imx_media_create_fwnode_pad_link(s) to v4l2-core as v4l2_create_fwnode_links_to_pad() and v4l2_create_fwnode_links(). Used by the video-mux, imx5/6/7 CSI's, and imx6/7 MIPI CSI-2 receivers in their bound notifiers.
- Introduced a new group id IMX_MEDIA_GRP_ID_CSI_MUX, the imx6/7 CSI's will set the bound subdev grp_id to this if the bound subdev is a video mux.
- Removed imx7_csi_get_upstream_endpoint(), replacing with simpler code, see above.

v4:
- Removed the endpoint parsing callback APIs from video-mux and imx drivers as suggested by Sakari, replacing with endpoint parsing local to the drivers and the use of v4l2_async_notifier_add_fwnode_remote_subdev(). As a result convenience function v4l2_async_register_fwnode_subdev() is no longer used and is reverted.

v3:
- The changes to the default behaviour in media_entity_get_fwnode_pad(), and the fixes to current media drivers that call it inconsistently, have been put-off to another time. Instead this version implements the get_fwnode_pad operation where required in the imx and video-mux subdevices to make media link creation work correctly. The improvements to media_entity_get_fwnode_pad() can wait to another patch series.

v2:
- rename/move the notifier-to-state inlines in imx7-mipi-csis.c and imx7-media-csi.c, suggested by Rui Silva.
- rewrite imx_media_create_links() to only add the missing media links from the imx6 MIPI CSI-2 receiver.

Steve Longerbeam (22):
media: entity: Pass entity to get_fwnode_pad operation
media: v4l2-subdev: add v4l2_subdev_get_fwnode_pad_1_to_1
media: v4l2-mc: add v4l2_create_fwnode_links helpers
media: video-mux: Parse information from firmware without using
callbacks
media: imx: Parse information from firmware without using callbacks Revert "media: v4l2-fwnode: Add a convenience function for registering
subdevs with notifiers"
media: imx: csi: Implement get_fwnode_pad op
media: video-mux: Implement get_fwnode_pad op
media: imx: mipi csi-2: Implement get_fwnode_pad op
media: imx: imx7-mipi-csis: Implement get_fwnode_pad op
media: imx: imx7-media-csi: Implement get_fwnode_pad op
media: video-mux: Create media links in bound notifier
media: imx: mipi csi-2: Create media links in bound notifier
media: imx7: mipi csis: Create media links in bound notifier
media: imx7: csi: Create media links in bound notifier
media: imx: csi: Create media links in bound notifier
media: imx7: csi: Remove imx7_csi_get_upstream_endpoint()
media: imx5/6/7: csi: Mark a bound video mux as a CSI mux
media: imx: csi: Lookup upstream endpoint with
imx_media_get_pad_fwnode
media: imx: Create missing links from CSI-2 receiver
media: imx: silence a couple debug messages
media: imx: TODO: Remove media link creation todos

 drivers/media/mc/mc-entity.c                  |   2 +-
 drivers/media/platform/video-mux.c            |  87 +++++++--
 drivers/media/v4l2-core/v4l2-fwnode.c         |  62 ------
 drivers/media/v4l2-core/v4l2-mc.c             |  95 +++++++++
 drivers/media/v4l2-core/v4l2-subdev.c         |  22 +++
 drivers/staging/media/imx/TODO                |  29 ---
 drivers/staging/media/imx/imx-media-csi.c     | 181 +++++++++++-------
 .../staging/media/imx/imx-media-dev-common.c  |  50 ++---
 drivers/staging/media/imx/imx-media-dev.c     |   2 +-
 .../staging/media/imx/imx-media-internal-sd.c |   6 +-
 drivers/staging/media/imx/imx-media-of.c      | 114 -----------
 drivers/staging/media/imx/imx-media-utils.c   |  33 ++++
 drivers/staging/media/imx/imx-media.h         |   6 +-
 drivers/staging/media/imx/imx6-mipi-csi2.c    |  93 +++++++--
 drivers/staging/media/imx/imx7-media-csi.c    | 160 +++++++++-------
 drivers/staging/media/imx/imx7-mipi-csis.c    | 107 ++++++++---
 include/media/media-entity.h                  |   3 +-
 include/media/v4l2-fwnode.h                   |  38 ----
 include/media/v4l2-mc.h                       |  48 +++++
 include/media/v4l2-subdev.h                   |  17 ++
 20 files changed, 660 insertions(+), 495 deletions(-)
Signature · 1 line
2.17.1