media: imx: Create media links in bound notifiers
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest22 patches 5 repliesIn review
- v523 patches 6 repliesSuperseded
- v417 patches 20 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 posting 2/2 | 17 patches | 6 replies | Superseded | |
| v3 posting 1/2 | 17 patches | 1 reply | Superseded | |
| v2 | 23 patches | 14 replies | Superseded | |
| v1 | 22 patches | 12 replies | Superseded |
Changes in v6 from the cover letter
- Renamed v4l2_subdev_get_fwnode_pad_default() to v4l2_subdev_get_fwnode_pad_1_to_1().
- Instead of verifying the endpoint itself is owned by the subdevice, it's sufficient and more efficient to verify the endpoint's port parent is the subdevice, in v4l2_subdev_get_fwnode_pad_1_to_1(). Suggested by Sakari.
- Dropped patch "media: entity: Modify default behavior of media_entity_get_fwnode_pad" again. It's not strictly needed for this patchset and can be revisited later.
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/22 | media: entity: Pass entity to get_fwnode_pad operationdrivers/ include/ | +3 | 0 replies | |
| 2/22 | media: v4l2-subdev: add v4l2_subdev_get_fwnode_pad_1_to_1drivers/ include/ | +39 | 0 replies | |
| 3/22 | media: v4l2-mc: add v4l2_create_fwnode_links helpersdrivers/ include/ | +143 | 0 replies | |
| 4/22 | media: video-mux: Parse information from firmware without using callbacksdrivers/ | +46 | 0 replies | |
| 5/22 | media: imx: Parse information from firmware without using callbacksdrivers/ drivers/ drivers/ +1 more | +192 | 0 replies | |
| 6/22 | Revert "media: v4l2-fwnode: Add a convenience function for registering subdevs with notifiers"drivers/ include/ | +0 | 0 replies | |
| 7/22 | media: imx: csi: Implement get_fwnode_pad opdrivers/ | +23 | 0 replies | |
| 8/22 | media: video-mux: Implement get_fwnode_pad opdrivers/ | +1 | 0 replies | |
| 9/22 | media: imx: mipi csi-2: Implement get_fwnode_pad opdrivers/ | +1 | 0 replies | |
| 10/22 | media: imx: imx7-mipi-csis: Implement get_fwnode_pad opdrivers/ | +1 | 1 reply | |
| 11/22 | media: imx: imx7-media-csi: Implement get_fwnode_pad opdrivers/ | +1 | 1 reply | |
| 12/22 | media: video-mux: Create media links in bound notifierdrivers/ | +22 | 0 replies | |
| 13/22 | media: imx: mipi csi-2: Create media links in bound notifierdrivers/ | +22 | 0 replies | |
| 14/22 | media: imx7: mipi csis: Create media links in bound notifierdrivers/ | +23 | 1 reply | |
| 15/22 | media: imx7: csi: Create media links in bound notifierdrivers/ | +22 | 0 replies | |
| 16/22 | media: imx: csi: Create media links in bound notifierdrivers/ | +21 | 0 replies | |
| 17/22 | media: imx7: csi: Remove imx7_csi_get_upstream_endpoint()drivers/ | +12 | 1 reply | |
| 18/22 | media: imx5/6/7: csi: Mark a bound video mux as a CSI muxdrivers/ drivers/ drivers/ | +35 | 1 reply | |
| 19/22 | media: imx: csi: Lookup upstream endpoint with imx_media_get_pad_fwnodedrivers/ drivers/ drivers/ | +40 | 0 replies | |
| 20/22 | media: imx: Create missing links from CSI-2 receiverdrivers/ drivers/ drivers/ | +17 | 0 replies | |
| 21/22 | media: imx: silence a couple debug messagesdrivers/ drivers/ drivers/ | +7 | 0 replies | |
| 22/22 | media: imx: TODO: Remove media link creation todosdrivers/ | +0 | 0 replies |
Reviews trailers per patch
10 of 22 patches have a Reviewed-by or Acked-by.
| Patch | Laurent Pinchart | Rui Miguel Silva |
|---|---|---|
| 1/22 | R-b | |
| 2/22 | ||
| 3/22 | ||
| 4/22 | ||
| 5/22 | ||
| 6/22 | ||
| 7/22 | R-b | |
| 8/22 | ||
| 9/22 | ||
| 10/22 | A-b | |
| 11/22 | A-b | |
| 12/22 | ||
| 13/22 | ||
| 14/22 | A-b | |
| 15/22 | R-b | |
| 16/22 | ||
| 17/22 | A-b | |
| 18/22 | A-b | |
| 19/22 | ||
| 20/22 | R-b | |
| 21/22 | R-b | |
| 22/22 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 00/22] media: imx: Create media links in bound notifiers
Move media link creation into the notifier bound callbacks in the set of subdevices required by imx (imx5/6/7 CSI, imx6/7 MIPI CSI-2 receivers, and video-mux).
Rui, Laurent:
AFAICT the i.MX7 CSI can only ever connect to a CSI mux, which really makes the function imx7_csi_get_upstream_endpoint() unnecessary. See patches 17/22 and 18/22, and let me know if that makes sense.
History:
v6:
- Renamed v4l2_subdev_get_fwnode_pad_default() to v4l2_subdev_get_fwnode_pad_1_to_1().
- Instead of verifying the endpoint itself is owned by the subdevice, it's sufficient and more efficient to verify the endpoint's port parent is the subdevice, in v4l2_subdev_get_fwnode_pad_1_to_1(). Suggested by Sakari.
- Dropped patch "media: entity: Modify default behavior of media_entity_get_fwnode_pad" again. It's not strictly needed for this patchset and can be revisited later.
v5:
- Revived patch "media: entity: Modify default behavior of media_entity_get_fwnode_pad" from v2.
- Added a v4l2_subdev_get_fwnode_pad_default, which can be used as a subdev's .get_fwnode_pad() operation if the subdev maps fwnode port id's and pad indexes 1:1. Used by video-mux, imx6/7 MIPI CSI-2 receivers, and imx7 CSI.
- Exported imx_media_create_fwnode_pad_link(s) to v4l2-core as v4l2_create_fwnode_links_to_pad() and v4l2_create_fwnode_links(). Used by the video-mux, imx5/6/7 CSI's, and imx6/7 MIPI CSI-2 receivers in their bound notifiers.
- Introduced a new group id IMX_MEDIA_GRP_ID_CSI_MUX, the imx6/7 CSI's will set the bound subdev grp_id to this if the bound subdev is a video mux.
- Removed imx7_csi_get_upstream_endpoint(), replacing with simpler code, see above.
v4:
- Removed the endpoint parsing callback APIs from video-mux and imx drivers as suggested by Sakari, replacing with endpoint parsing local to the drivers and the use of v4l2_async_notifier_add_fwnode_remote_subdev(). As a result convenience function v4l2_async_register_fwnode_subdev() is no longer used and is reverted.
v3:
- The changes to the default behaviour in media_entity_get_fwnode_pad(), and the fixes to current media drivers that call it inconsistently, have been put-off to another time. Instead this version implements the get_fwnode_pad operation where required in the imx and video-mux subdevices to make media link creation work correctly. The improvements to media_entity_get_fwnode_pad() can wait to another patch series.
v2:
- rename/move the notifier-to-state inlines in imx7-mipi-csis.c and imx7-media-csi.c, suggested by Rui Silva.
- rewrite imx_media_create_links() to only add the missing media links from the imx6 MIPI CSI-2 receiver.
Steve Longerbeam (22):
media: entity: Pass entity to get_fwnode_pad operation
media: v4l2-subdev: add v4l2_subdev_get_fwnode_pad_1_to_1
media: v4l2-mc: add v4l2_create_fwnode_links helpers
media: video-mux: Parse information from firmware without using
callbacks
media: imx: Parse information from firmware without using callbacks Revert "media: v4l2-fwnode: Add a convenience function for registering
subdevs with notifiers"
media: imx: csi: Implement get_fwnode_pad op
media: video-mux: Implement get_fwnode_pad op
media: imx: mipi csi-2: Implement get_fwnode_pad op
media: imx: imx7-mipi-csis: Implement get_fwnode_pad op
media: imx: imx7-media-csi: Implement get_fwnode_pad op
media: video-mux: Create media links in bound notifier
media: imx: mipi csi-2: Create media links in bound notifier
media: imx7: mipi csis: Create media links in bound notifier
media: imx7: csi: Create media links in bound notifier
media: imx: csi: Create media links in bound notifier
media: imx7: csi: Remove imx7_csi_get_upstream_endpoint()
media: imx5/6/7: csi: Mark a bound video mux as a CSI mux
media: imx: csi: Lookup upstream endpoint with
imx_media_get_pad_fwnode
media: imx: Create missing links from CSI-2 receiver
media: imx: silence a couple debug messages
media: imx: TODO: Remove media link creation todos
drivers/media/mc/mc-entity.c | 2 +- drivers/media/platform/video-mux.c | 87 +++++++-- drivers/media/v4l2-core/v4l2-fwnode.c | 62 ------ drivers/media/v4l2-core/v4l2-mc.c | 95 +++++++++ drivers/media/v4l2-core/v4l2-subdev.c | 22 +++ drivers/staging/media/imx/TODO | 29 --- drivers/staging/media/imx/imx-media-csi.c | 181 +++++++++++------- .../staging/media/imx/imx-media-dev-common.c | 50 ++--- drivers/staging/media/imx/imx-media-dev.c | 2 +- .../staging/media/imx/imx-media-internal-sd.c | 6 +- drivers/staging/media/imx/imx-media-of.c | 114 ----------- drivers/staging/media/imx/imx-media-utils.c | 33 ++++ drivers/staging/media/imx/imx-media.h | 6 +- drivers/staging/media/imx/imx6-mipi-csi2.c | 93 +++++++-- drivers/staging/media/imx/imx7-media-csi.c | 160 +++++++++------- drivers/staging/media/imx/imx7-mipi-csis.c | 107 ++++++++--- include/media/media-entity.h | 3 +- include/media/v4l2-fwnode.h | 38 ---- include/media/v4l2-mc.h | 48 +++++ include/media/v4l2-subdev.h | 17 ++ 20 files changed, 660 insertions(+), 495 deletions(-)
Signature · 1 line
2.17.1