Skip to content

backup improvements

Vladimir Sementsov-Ogievskiy qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 16 repliesIn review
  2. v27 patches 7 repliesSuperseded
  3. v18 patches 16 repliesSuperseded

Changes in v3 from the cover letter

03: Ha, fix real bug, we shouldn't touch src before handling write-zero,
as src may be NULL. So, replace align and max_transfer calculation together with max_transfer == 0 check. Drop comment, as there is no special place for it now..
04: add Max's r-b:
06-07: rewrite to keep bounce_buffer sharing between iterations and to
limit allocation [Eric]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7block/backup: deal with zero detectionblock/backup.c blockdev.c+10 -130 replies
2/7block/backup: refactor write_flagsblock/backup.c+12 -120 replies
3/7block/io: handle alignment and max_transfer for copy_rangeblock/io.c+36 -82 replies
4/7block/backup: drop handling of max_transfer for copy_rangeblock/backup.c+2 -90 replies
5/7block/backup: fix backup_cow_with_offload for last clusterblock/backup.c+1 -10 replies
6/7block/backup: teach backup_cow_with_bounce_buffer to copy more at onceblock/backup.c+41 -2414 replies
7/7block/backup: merge duplicated logic into backup_do_cowblock/backup.c+38 -590 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchMax ReitzJohn Snow
1/7R-b
2/7R-b R-b
3/7R-b
4/7R-b
5/7R-b
6/7
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/7] backup improvements

Hi all!

There are some fixes and refactorings I need on my way to resend my backup-top series. It's obvious now that I need to share copying code between backup and backup-top, as backup copying code becomes smarter and more complicated. So the goal of the series is to make copying code more share-able.

Based-on: https://github.com/jnsnow/qemu bitmaps

v3:
03: Ha, fix real bug, we shouldn't touch src before handling write-zero,
as src may be NULL. So, replace align and max_transfer calculation together with max_transfer == 0 check. Drop comment, as there is no special place for it now..
04: add Max's r-b:
06-07: rewrite to keep bounce_buffer sharing between iterations and to
limit allocation [Eric]

v2 (by Max's comments):

02: Add Max's r-b
03: - split out backup changes to 03
- handle common max_transfer = 0 case
04: splat out from 02
06: fix allocation size
07: - rebase on 06 changes
- add Max's r-b

two patches are dropped or postponed for the next step

Vladimir Sementsov-Ogievskiy (7):
block/backup: deal with zero detection
block/backup: refactor write_flags
block/io: handle alignment and max_transfer for copy_range block/backup: drop handling of max_transfer for copy_range block/backup: fix backup_cow_with_offload for last cluster block/backup: teach backup_cow_with_bounce_buffer to copy more at once block/backup: merge duplicated logic into backup_do_cow

 block/backup.c | 154 ++++++++++++++++++++++---------------------------
 block/io.c     |  44 +++++++++++---
 blockdev.c     |   8 +--
 3 files changed, 110 insertions(+), 96 deletions(-)
Signature · 1 line
2.18.0