Skip to content

enhance lock debugging

Juergen Gross xen-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 5 repliesIn review
  2. v45 patches 2 repliesSuperseded
  3. v35 patches 23 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches0 repliesSuperseded
v14 patches31 repliesSuperseded

Changes in v5 from the cover letter

- add BUILD_BUG_ON() in patch 1

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5xen/spinlocks: in debug builds store cpu holding the lockxen/common/spinlock.c xen/include/xen/spinlock.h+49 -163 replies
2/5xen: add new CONFIG_DEBUG_LOCKS optionxen/Kconfig.debug xen/common/spinlock.c xen/include/xen/spinlock.h+10 -30 replies
3/5xen: print lock profile info in panic()xen/Kconfig.debug xen/arch/arm/xen.lds.S xen/arch/x86/domain.c +6 more+47 -370 replies
4/5xen: modify lock profiling interfacetools/libxc/xc_misc.c tools/misc/xenlockprof.c xen/common/domain.c +3 more+107 -620 replies
5/5xen: add function name to lock profiling dataxen/common/spinlock.c xen/include/xen/spinlock.h+16 -42 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchJan Beulich
1/5R-b
2/5R-b
3/5A-b
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [Xen-devel] [PATCH v5 0/5] enhance lock debugging

While hunting a locking problem in my core scheduling series I have added some debugging aids to spinlock handling making it easier to find the root cause for the problem.

Making use of the already existing lock profiling and enhancing it a little bit produces some really valuable diagnostic data e.g. when a NMI watchdog is triggering a crash.

Changes in V5:
- add BUILD_BUG_ON() in patch 1

Changes in V4:
- some comments by Jan Beulich addressed
- replaced patch 5 with another approach to make lock names unique

Changes in V3:
- rebase to current staging (after realizing that patch 4 still applied, but resulting in patching a wrong function)

Changes in V2:
- multiple comments addressed
- added patch 5

Juergen Gross (5):
xen/spinlocks: in debug builds store cpu holding the lock
xen: add new CONFIG_DEBUG_LOCKS option
xen: print lock profile info in panic()
xen: modify lock profiling interface
xen: add function name to lock profiling data

 tools/libxc/xc_misc.c       |   1 +
 tools/misc/xenlockprof.c    |  17 +---
 xen/Kconfig.debug           |  10 ++-
 xen/arch/arm/xen.lds.S      |  13 +--
 xen/arch/x86/domain.c       |   2 +-
 xen/arch/x86/xen.lds.S      |  13 +--
 xen/common/domain.c         |   4 +-
 xen/common/keyhandler.c     |   2 +-
 xen/common/spinlock.c       | 188 ++++++++++++++++++++++++++++++++------------
 xen/common/sysctl.c         |   2 +-
 xen/drivers/char/console.c  |   4 +-
 xen/include/public/sysctl.h |  11 +--
 xen/include/xen/spinlock.h  |  76 +++++++++++-------
 13 files changed, 225 insertions(+), 118 deletions(-)
Signature · 7 lines
2.16.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel