enhance lock debugging
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest5 patches 5 repliesIn review
- v45 patches 2 repliesSuperseded
- v35 patches 23 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 5 patches | 0 replies | Superseded | |
| v1 | 4 patches | 31 replies | Superseded |
Changes in v5 from the cover letter
- add BUILD_BUG_ON() in patch 1
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | xen/spinlocks: in debug builds store cpu holding the lockxen/ xen/ | +49 | 3 replies | |
| 2/5 | xen: add new CONFIG_DEBUG_LOCKS optionxen/ xen/ xen/ | +10 | 0 replies | |
| 3/5 | xen: print lock profile info in panic()xen/ xen/ xen/ +6 more | +47 | 0 replies | |
| 4/5 | xen: modify lock profiling interfacetools/ tools/ xen/ +3 more | +107 | 0 replies | |
| 5/5 | xen: add function name to lock profiling dataxen/ xen/ | +16 | 2 replies |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Jan Beulich |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | A-b |
| 4/5 | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Xen-devel] [PATCH v5 0/5] enhance lock debugging
While hunting a locking problem in my core scheduling series I have added some debugging aids to spinlock handling making it easier to find the root cause for the problem.
Making use of the already existing lock profiling and enhancing it a little bit produces some really valuable diagnostic data e.g. when a NMI watchdog is triggering a crash.
Changes in V5:
- add BUILD_BUG_ON() in patch 1
Changes in V4:
- some comments by Jan Beulich addressed
- replaced patch 5 with another approach to make lock names unique
Changes in V3:
- rebase to current staging (after realizing that patch 4 still applied, but resulting in patching a wrong function)
Changes in V2:
- multiple comments addressed
- added patch 5
Juergen Gross (5):
xen/spinlocks: in debug builds store cpu holding the lock
xen: add new CONFIG_DEBUG_LOCKS option
xen: print lock profile info in panic()
xen: modify lock profiling interface
xen: add function name to lock profiling data
tools/libxc/xc_misc.c | 1 + tools/misc/xenlockprof.c | 17 +--- xen/Kconfig.debug | 10 ++- xen/arch/arm/xen.lds.S | 13 +-- xen/arch/x86/domain.c | 2 +- xen/arch/x86/xen.lds.S | 13 +-- xen/common/domain.c | 4 +- xen/common/keyhandler.c | 2 +- xen/common/spinlock.c | 188 ++++++++++++++++++++++++++++++++------------ xen/common/sysctl.c | 2 +- xen/drivers/char/console.c | 4 +- xen/include/public/sysctl.h | 11 +-- xen/include/xen/spinlock.h | 76 +++++++++++------- 13 files changed, 225 insertions(+), 118 deletions(-)
Signature · 7 lines
2.16.4 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel