net/eth: Remove duplicated tcp/udp_hdr structures
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macroshw/ | +2 | 0 replies | |
| 2/6 | net/colo-compare: Use the tcp_header structurenet/ | +7 | 0 replies | |
| 3/6 | net/filter-rewriter: Use the tcp_header structurenet/ | +21 | 0 replies | |
| 4/6 | hw/net/vmxnet3: Use the tcp_header structurehw/ hw/ | +5 | 0 replies | |
| 5/6 | net/eth: Remove the unused tcp_hdr structureinclude/ | +8 | 0 replies | |
| 6/6 | net/eth: Remove the single use of udp_hdr structurehw/ include/ | +1 | 0 replies |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Dmitry Fleytman |
|---|---|
| Series | R-b |
| 1/6 | |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures
This is a preparatory cleanup series.
Commit 75020a70215 introduced 4 very equivalent structures:
- tcp_header and tcp_hdr,
- udp_header and udp_hdr.
Choose the most widely use in the codebase, which happens to provide convenient bitfields manipulation macros and is not endian-specific.
Philippe Mathieu-Daudé (6):
hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macros net/colo-compare: Use the tcp_header structure net/filter-rewriter: Use the tcp_header structure hw/net/vmxnet3: Use the tcp_header structure
net/eth: Remove the unused tcp_hdr structure
net/eth: Remove the single use of udp_hdr structure
hw/net/net_rx_pkt.c | 2 +- hw/net/net_tx_pkt.c | 9 +++++---- hw/net/virtio-net.c | 9 ++------- include/net/eth.h | 47 ++++++++----------------------------------- net/colo-compare.c | 14 ++++++------- net/filter-rewriter.c | 37 +++++++++++++++++++--------------- 6 files changed, 44 insertions(+), 74 deletions(-)
Signature · 1 line
2.20.1