Skip to content

net/eth: Remove duplicated tcp/udp_hdr structures

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macroshw/net/virtio-net.c+2 -70 replies
2/6net/colo-compare: Use the tcp_header structurenet/colo-compare.c+7 -70 replies
3/6net/filter-rewriter: Use the tcp_header structurenet/filter-rewriter.c+21 -160 replies
4/6hw/net/vmxnet3: Use the tcp_header structurehw/net/net_rx_pkt.c hw/net/net_tx_pkt.c+5 -40 replies
5/6net/eth: Remove the unused tcp_hdr structureinclude/net/eth.h+8 -320 replies
6/6net/eth: Remove the single use of udp_hdr structurehw/net/net_tx_pkt.c include/net/eth.h+1 -80 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDmitry Fleytman
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures

This is a preparatory cleanup series.

Commit 75020a70215 introduced 4 very equivalent structures:
- tcp_header and tcp_hdr,
- udp_header and udp_hdr.

Choose the most widely use in the codebase, which happens to provide convenient bitfields manipulation macros and is not endian-specific.

Philippe Mathieu-Daudé (6):
hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macros net/colo-compare: Use the tcp_header structure net/filter-rewriter: Use the tcp_header structure hw/net/vmxnet3: Use the tcp_header structure
net/eth: Remove the unused tcp_hdr structure
net/eth: Remove the single use of udp_hdr structure

 hw/net/net_rx_pkt.c   |  2 +-
 hw/net/net_tx_pkt.c   |  9 +++++----
 hw/net/virtio-net.c   |  9 ++-------
 include/net/eth.h     | 47 ++++++++-----------------------------------
 net/colo-compare.c    | 14 ++++++-------
 net/filter-rewriter.c | 37 +++++++++++++++++++---------------
 6 files changed, 44 insertions(+), 74 deletions(-)
Signature · 1 line
2.20.1