Skip to content

btrfs: tree-checker: Add extent items check

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Changelog from the cover letter

v1.1:
- If branches optimization
Make some if branches more readable.

- Range notion update
Use regular set notion ([],[),(],()) to show possible value range.

- Fix a wrong range notion
The valid range for tree level is [0, MAX_LEVEL - 1], not [0, MAX_LEVEL -1)

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: tree-checker: Add EXTENT_ITEM and METADATA_ITEM checkfs/btrfs/tree-checker.c+250 -01 reply
2/3btrfs: tree-checker: Add simple keyed refs checkfs/btrfs/tree-checker.c+39 -13 replies
3/3btrfs: tree-checker: Add EXTENT_DATA_REF checkfs/btrfs/ctree.h fs/btrfs/extent-tree.c fs/btrfs/tree-checker.c+50 -10 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchDavid Sterba
1/3
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1.2 0/3] btrfs: tree-checker: Add extent items check

Finally, we are going to add tree-checker support for extent items, which includes:
- EXTENT_ITEM/METADATA_ITEM
Which futher contains inline backrefs of:
* TREE_BLOCK_REF
* SHARED_BLOCK_REF
* EXETNT_DATA_REF
* SHARED_DATA_REF

- TREE_BLOCK_REF
- SHARED_BLOCK_REF
- EXTENT_DATA_REF
- SHARED_DATA_REF
Keyed version of the above types

The complexity of the on-disk format can be found in the first patch, which contains a basic introduction as comment.

Hidden pitfalls are everywhere, e.g. inlined EXTENT_DATA_REF don't use iref->offset, but put its own data at iref->offset.
But SHARED_DATA_REF uses iref->offset, and put extra data after iref.

Such on-disk layout makes sense, but definitely a mess to read. Thankfully we at least have print-tree code from btrfs-progs as a reference.

Changelog:
v1.1:
- If branches optimization
Make some if branches more readable.

- Range notion update
Use regular set notion ([],[),(],()) to show possible value range.

- Fix a wrong range notion
The valid range for tree level is [0, MAX_LEVEL - 1], not [0, MAX_LEVEL -1)

v1.2:
- Use "unsigned long" for pointer convertion

- Use "%zu" format for sizeof() in the 3rd patch

Qu Wenruo (3):
btrfs: tree-checker: Add EXTENT_ITEM and METADATA_ITEM check
btrfs: tree-checker: Add simple keyed refs check
btrfs: tree-checker: Add EXTENT_DATA_REF check

 fs/btrfs/ctree.h        |   1 +
 fs/btrfs/extent-tree.c  |   2 +-
 fs/btrfs/tree-checker.c | 336 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 338 insertions(+), 1 deletion(-)
Signature · 1 line
2.22.0