Skip to content

Handle the case when KernelShark is started as Root

Yordan Karadzhov (VMware) linux-trace-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesNew
  2. v25 patches 4 repliesSuperseded
  3. v13 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Polishing the text of the warning/error messages in patches 1/5 and 5/5. The modifications have been suggested by Steven.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5kernel-shark: Show warning message when running as Rootkernel-shark/src/KsMainWindow.cpp kernel-shark/src/KsMainWindow.hpp+30 -00 replies
2/5kernel-shark: Don't use pkexec when running as Rootkernel-shark/src/KsMainWindow.cpp+32 -150 replies
3/5kernel-shark: Use standart error message in KsMainWindow::_record()kernel-shark/src/KsMainWindow.cpp+1 -30 replies
4/5kernel-shark: Optimize the error messages when "Record" fails to startkernel-shark/src/KsMainWindow.cpp kernel-shark/src/KsMainWindow.hpp+9 -70 replies
5/5kernel-shark: Better formatting of the error messages from "Record"kernel-shark/src/KsMainWindow.cpp+2 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] Handle the case when KernelShark is started as Root

A patch set implementing the improvements suggested here:

https://bugzilla.kernel.org/show_bug.cgi?id=204475

Plus a minor improvements of the error messages printed when something goes wrong withe the "Record" dialog.

v2 changes:
- Correcting typos in patch 1/5
- Fixing a bug in patch 2/5. trace-cmd now gets correctly formatted list of command line arguments.
- Patches 4/5 and 5/5 are new.

v3 changes:
- Polishing the text of the warning/error messages in patches 1/5 and 5/5. The modifications have been suggested by Steven.

Yordan Karadzhov (VMware) (5):
kernel-shark: Show warning message when running as Root
kernel-shark: Don't use pkexec when running as Root
kernel-shark: Use standart error message in KsMainWindow::_record()
kernel-shark: Optimize the error messages when "Record" fails to start
kernel-shark: Better formatting of the error messages from "Record"

 kernel-shark/src/KsMainWindow.cpp | 90 +++++++++++++++++++++++--------
 kernel-shark/src/KsMainWindow.hpp |  4 ++
 2 files changed, 71 insertions(+), 23 deletions(-)
Signature · 1 line
2.20.1