Skip to content

Cleanup IOMMU passthrough setting (and disable IOMMU Passthrough when SME is active)

Joerg Roedel linux-doc linux-ia64 linux-iommu lkml 3 versions – Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 3 repliesApplied
  2. v210 patches 6 repliesSuperseded
  3. v13 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Added 'bool cmd_line' parameter to iommu_set_default_*() functions, so that we correctly recognize iommu=pt/nopt command line parameters

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/11iommu: Remember when default domain type was set on kernel command linedrivers/iommu/iommu.c+15 -00 replies
2/11iommu: Add helpers to set/get default domain typedrivers/iommu/iommu.c include/linux/iommu.h+38 -00 replies
3/11iommu: Use Functions to set default domain type in iommu_set_def_domain_type()drivers/iommu/iommu.c+4 -20 replies
4/11iommu/amd: Request passthrough mode from IOMMU coredrivers/iommu/amd_iommu.c+3 -30 replies
5/11iommu/vt-d: Request passthrough mode from IOMMU coredrivers/iommu/intel-iommu.c+1 -10 replies
6/11x86/dma: Get rid of iommu_pass_througharch/x86/include/asm/iommu.h arch/x86/kernel/pci-dma.c+3 -181 reply
7/11ia64: Get rid of iommu_pass_througharch/ia64/include/asm/iommu.h arch/ia64/kernel/pci-dma.c+0 -40 replies
8/11iommu: Print default domain type on bootdrivers/iommu/iommu.c+29 -10 replies
9/11iommu: Set default domain type at runtimedrivers/iommu/iommu.c+15 -80 replies
10/11iommu: Disable passthrough mode when SME is activedrivers/iommu/iommu.c+5 -01 reply
11/11Documentation: Update Documentation for iommu.passthroughDocumentation/admin-guide/kernel-parameters.txt+1 -10 replies

Reviews trailers per patch

2 of 11 patches have a Reviewed-by or Acked-by.

PatchBorislav PetkovTom Lendacky
1/11
2/11
3/11
4/11
5/11
6/11R-b
7/11
8/11
9/11
10/11R-b T-b
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH 00/11 v3] Cleanup IOMMU passthrough setting (and disable IOMMU Passthrough when SME is active)

From: Joerg Roedel <[email protected]>

Hi,

This patch-set started out small to overwrite the default passthrough setting (through CONFIG_IOMMU_DEFAULT_PASSTHROUGH=y) when SME is active.

But on the way to that Tom reminded me that the current ways to configure passthrough/no-passthrough modes for IOMMU on x86 is a mess. So I added a few more patches to clean that up a bit, getting rid of the iommu_pass_through variable on the way.This information is now kept only in iommu code, with helpers to change that setting from architecture code.

And of course this patch-set still disables IOMMU Passthrough mode when SME is active even when CONFIG_IOMMU_DEFAULT_PASSTHROUGH=y is set.

The reason for that change is that SME with passthrough mode turned out to be fragile with devices requiring SWIOTLB, mainly because SWIOTLB has a maximum allocation size of 256kb and a limit overall size of the bounce buffer.

Therefore having IOMMU in translation mode by default is better when SME is active on a system.

Please review.

Thanks,

Joerg

Changes since v2:

- Added 'bool cmd_line' parameter to iommu_set_default_*() functions, so that we correctly recognize iommu=pt/nopt command line parameters

Changes since v1:

- Cleaned up the kernel command line parameters to configure passthrough/translated mode, getting rid of the global iommu_pass_through variable

Joerg Roedel (11):
iommu: Remember when default domain type was set on kernel command line
iommu: Add helpers to set/get default domain type
iommu: Use Functions to set default domain type in iommu_set_def_domain_type() iommu/amd: Request passthrough mode from IOMMU core
iommu/vt-d: Request passthrough mode from IOMMU core
x86/dma: Get rid of iommu_pass_through
ia64: Get rid of iommu_pass_through
iommu: Print default domain type on boot
iommu: Set default domain type at runtime
iommu: Disable passthrough mode when SME is active
Documentation: Update Documentation for iommu.passthrough

 Documentation/admin-guide/kernel-parameters.txt |  2 +-
 arch/ia64/include/asm/iommu.h                   |  2 -
 arch/ia64/kernel/pci-dma.c                      |  2 -
 arch/x86/include/asm/iommu.h                    |  1 -
 arch/x86/kernel/pci-dma.c                       | 20 +-----
 drivers/iommu/amd_iommu.c                       |  6 +-
 drivers/iommu/intel-iommu.c                     |  2 +-
 drivers/iommu/iommu.c                           | 93 +++++++++++++++++++++++--
 include/linux/iommu.h                           | 16 +++++
 9 files changed, 110 insertions(+), 34 deletions(-)
Signature · 1 line
2.16.4