Skip to content

Simplify PCIe hotplug indicator control

Denis Efremov linux-pci lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 3 repliesIn review
  2. v34 patches 13 repliesSuperseded
  3. v24 patches 14 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches6 repliesSuperseded

Changes in v4 from the cover letter

- Changed the inputs validation in pciehp_set_indicators()
- Moved PCI_EXP_SLTCTL_ATTN_IND_NONE, PCI_EXP_SLTCTL_PWR_IND_NONE to drivers/pci/hotplug/pciehp.h and set to -1 for not interfering with reserved values in the PCIe Base spec
- Added set_power_indicator define

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4PCI: pciehp: Add pciehp_set_indicators() to jointly set LED indicatorsdrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_hpc.c+26 -00 replies
2/4PCI: pciehp: Switch LED indicators with a single writedrivers/pci/hotplug/pciehp_ctrl.c drivers/pci/hotplug/pciehp_hpc.c+12 -110 replies
3/4PCI: pciehp: Remove pciehp_set_attention_status()drivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_core.c drivers/pci/hotplug/pciehp_hpc.c +1 more+7 -270 replies
4/4PCI: pciehp: Remove pciehp_green_led_{on,off,blink}()drivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_ctrl.c drivers/pci/hotplug/pciehp_hpc.c+7 -420 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchKuppuswamy SathyanarayananLukas Wunner
1/4
2/4R-b R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] Simplify PCIe hotplug indicator control

PCIe defines two optional hotplug indicators: a Power indicator and an Attention indicator. Both are controlled by the same register, and each can be on, off or blinking. The current interfaces (pciehp_green_led_{on,off,blink}() and pciehp_set_attention_status()) are non-uniform and require two register writes in many cases where we could do one.

This patchset introduces the new function pciehp_set_indicators(). It allows one to set two indicators with a single register write. All calls to previous interfaces (pciehp_green_led_* and pciehp_set_attention_status()) are replaced with a new one. Thus, the amount of duplicated code for setting indicators is reduced.

Changes in v4:
- Changed the inputs validation in pciehp_set_indicators()
- Moved PCI_EXP_SLTCTL_ATTN_IND_NONE, PCI_EXP_SLTCTL_PWR_IND_NONE to drivers/pci/hotplug/pciehp.h and set to -1 for not interfering with reserved values in the PCIe Base spec
- Added set_power_indicator define

Changes in v3:
- Changed pciehp_set_indicators() to work with existing PCI_EXP_SLTCTL_* macros
- Reworked the inputs validation in pciehp_set_indicators()
- Removed pciehp_set_attention_status() and pciehp_green_led_*() completely

Denis Efremov (4):
PCI: pciehp: Add pciehp_set_indicators() to jointly set LED indicators
PCI: pciehp: Switch LED indicators with a single write
PCI: pciehp: Remove pciehp_set_attention_status()
PCI: pciehp: Remove pciehp_green_led_{on,off,blink}()

 drivers/pci/hotplug/pciehp.h      | 12 ++++--
 drivers/pci/hotplug/pciehp_core.c |  7 ++-
 drivers/pci/hotplug/pciehp_ctrl.c | 26 +++++------
 drivers/pci/hotplug/pciehp_hpc.c  | 72 +++++++------------------------
 include/uapi/linux/pci_regs.h     |  1 +
 5 files changed, 45 insertions(+), 73 deletions(-)
Signature · 1 line
2.21.0