Skip to content

intel_iommu: Do sanity check of vfio-pci earlier

Peter Xu qemu-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesNew
  2. v24 patches 1 replySuperseded
  3. v1 RFC4 patches 20 repliesSuperseded

Changes in v3 from the cover letter

- repost with the correct tree

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4intel_iommu: Sanity check vfio-pci config on machine init donehw/i386/intel_iommu.c+36 -30 replies
2/4qdev/machine: Introduce hotplug_allowed hookhw/core/qdev.c include/hw/boards.h include/hw/qdev-core.h +1 more+34 -00 replies
3/4pc/q35: Disallow vfio-pci hotplug without VT-d caching modehw/i386/pc.c+21 -00 replies
4/4intel_iommu: Remove the caching-mode check during flag changehw/i386/intel_iommu.c+0 -40 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchEric Auger
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/4] intel_iommu: Do sanity check of vfio-pci earlier

v3:
- repost with the correct tree

v2:
- rebase to master [Eric]
- add r-bs for Eric
- remove RFC tag

The VT-d code has some defects, one of them is that we cannot detect the misuse of vIOMMU and vfio-pci early enough.

For example, logically this is not allowed:

  -device intel-iommu,caching-mode=off \
  -device vfio-pci,host=05:00.0

Because the caching mode is required to make vfio-pci devices functional.

Previously we did this sanity check in vtd_iommu_notify_flag_changed() as when the memory regions change their attributes. However that's too late in most cases! Because the memory region layouts will only change after IOMMU is enabled, and that's in most cases during the guest OS boots. So when the configuration is wrong, we will only bail out during the guest boots rather than simply telling the user before QEMU starts.

The same problem happens on device hotplug, say, when we have this:

-device intel-iommu,caching-mode=off

Then we do something like:

(HMP) device_add vfio-pci,host=05:00.0,bus=pcie.1

If at that time the vIOMMU is enabled in the guest then the QEMU process will simply quit directly due to this hotplug event. This is a bit insane...

This series tries to solve above two problems by introducing two sanity checks upon these places separately:

- machine done
- hotplug device

This is a bit awkward but I hope this could be better than before. There is of course other solutions like hard-code the check into vfio-pci but I feel it even more unpretty. I didn't think out any better way to do this, if there is please kindly shout out.

Please have a look to see whether this would be acceptable, thanks.

Peter Xu (4):
intel_iommu: Sanity check vfio-pci config on machine init done qdev/machine: Introduce hotplug_allowed hook
pc/q35: Disallow vfio-pci hotplug without VT-d caching mode
intel_iommu: Remove the caching-mode check during flag change

 hw/core/qdev.c         | 17 +++++++++++++++++
 hw/i386/intel_iommu.c  | 41 +++++++++++++++++++++++++++++++++++------
 hw/i386/pc.c           | 21 +++++++++++++++++++++
 include/hw/boards.h    |  9 +++++++++
 include/hw/qdev-core.h |  1 +
 qdev-monitor.c         |  7 +++++++
 6 files changed, 90 insertions(+), 6 deletions(-)
Signature · 1 line
2.21.0