Skip to content

s390x/mmu: Storage key reference and change bit handling

David Hildenbrand qemu-devel 3 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 6 repliesApplied
  2. v26 patches 13 repliesApplied
  3. v16 patches 14 repliesSuperseded

Changes in v3 from the cover letter

- Reshuffled patches to avoid a temporary uninitialized return value
- Minor updates to patch descriptions
- "s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE" -- Updated comments
- "s390x/mmu: Factor out storage key handling"
-- Reduce indentation

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/6s390x/mmu: Trace the right value if setting/getting the storage key failstarget/s390x/mmu_helper.c+4 -21 reply
2/6s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug()target/s390x/helper.c+5 -00 replies
3/6s390x/tcg: Rework MMU selection for instruction fetchestarget/s390x/cpu.h target/s390x/mmu_helper.c+22 -231 reply
4/6s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBEtarget/s390x/mem_helper.c+10 -01 reply
5/6s390x/mmu: Better storage key reference and change bit handlingtarget/s390x/mmu_helper.c+19 -50 replies
6/6s390x/mmu: Factor out storage key handlingtarget/s390x/mmu_helper.c+71 -440 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchThomas HuthCornelia HuckAlex Bennée
1/6R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b A-b
5/6R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/6] s390x/mmu: Storage key reference and change bit handling

The first two patches are modified patches from:

    [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions

This series primarily fixes minor things in the storage key handling code in the MMU and implements fairly reliable reference and change bit handling for TCG. To track the reference and change bit, we have to invalidate TLB entries whenever the storage key is changed by the guest and make sure not TLB entry is writable in case the storage key does not indicate a change already.

With this series, the kvm-unit-test "skey" now passes. \o/

v2 -> v3:
- Reshuffled patches to avoid a temporary uninitialized return value
- Minor updates to patch descriptions
- "s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE" -- Updated comments
- "s390x/mmu: Factor out storage key handling"
-- Reduce indentation

v1 -> v2:
- "s390x/tcg: Rework MMU selection for instruction fetches" -- Cleanup return value handling
- Added RB's

Cc Alex Bennée <[email protected]>

David Hildenbrand (6):
s390x/mmu: Trace the right value if setting/getting the storage key
fails
s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug() s390x/tcg: Rework MMU selection for instruction fetches s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE s390x/mmu: Better storage key reference and change bit handling s390x/mmu: Factor out storage key handling

 target/s390x/cpu.h        |   7 ++
 target/s390x/helper.c     |   5 ++
 target/s390x/mem_helper.c |  10 +++
 target/s390x/mmu_helper.c | 135 ++++++++++++++++++++++++--------------
 4 files changed, 107 insertions(+), 50 deletions(-)
Signature · 1 line
2.21.0