Skip to content

xfsprogs: support fscrypt API additions in xfs_io

Eric Biggers fstests linux-fscrypt linux-xfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 1 replyIn review
  2. v28 patches 2 repliesSuperseded
  3. v1 RFC8 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- Generate the encryption modes for 'help set_encpolicy'.
- Mention '-a' in all relevant places in the help for rm_enckey.
- Mark strings for translation.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9xfs_io/encrypt: remove unimplemented encryption modesio/encrypt.c+1 -50 replies
2/9xfs_io/encrypt: update to UAPI definitions from Linux v5.4io/encrypt.c+122 -380 replies
3/9xfs_io/encrypt: generate encryption modes for 'help set_encpolicy'io/encrypt.c+19 -100 replies
4/9xfs_io/encrypt: add new encryption modesio/encrypt.c+3 -00 replies
5/9xfs_io/encrypt: extend 'get_encpolicy' to support v2 policiesio/encrypt.c man/man8/xfs_io.8+149 -190 replies
6/9xfs_io/encrypt: extend 'set_encpolicy' to support v2 policiesio/encrypt.c man/man8/xfs_io.8+199 -560 replies
7/9xfs_io/encrypt: add 'add_enckey' commandio/encrypt.c man/man8/xfs_io.8+124 -00 replies
8/9xfs_io/encrypt: add 'rm_enckey' commandio/encrypt.c man/man8/xfs_io.8+90 -00 replies
9/9xfs_io/encrypt: add 'enckey_status' commandio/encrypt.c man/man8/xfs_io.8+77 -00 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric Sandeen
SeriesR-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/9] xfsprogs: support fscrypt API additions in xfs_io

Hello,

This patchset updates xfs_io to support the new fscrypt ioctls that were merged for 5.4 (https://git.kernel.org/torvalds/c/734d1ed83e1f9b7b).

New commands are added to wrap the new ioctls to manage filesystem encryption keys: 'add_enckey', 'rm_enckey', and 'enckey_status'. Also, the existing 'get_encpolicy' and 'set_encpolicy' commands are updated to support getting/setting v2 encryption policies.

The purpose of all this is to allow xfstests to test these new APIs.

Note: currently only ext4, f2fs, and ubifs support encryption. But I was told previously that since the fscrypt API is generic and may be supported by XFS in the future, the command-line wrappers for the fscrypt ioctls should be in xfs_io rather than in xfstests directly
(https://marc.info/?l=fstests&m=147976255831951&w=2).

This patchset applies to the latest "for-next" branch of xfsprogs (commit ac8b6c380865). It can also be retrieved from tag "fscrypt-key-mgmt-improvements_2019-09-27" of
https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfsprogs-dev.git

Changes v2 => v3:
- Generate the encryption modes for 'help set_encpolicy'.
- Mention '-a' in all relevant places in the help for rm_enckey.
- Mark strings for translation.

No changes v1 => v2.

Eric Biggers (9):
xfs_io/encrypt: remove unimplemented encryption modes xfs_io/encrypt: update to UAPI definitions from Linux v5.4 xfs_io/encrypt: generate encryption modes for 'help set_encpolicy' xfs_io/encrypt: add new encryption modes xfs_io/encrypt: extend 'get_encpolicy' to support v2 policies xfs_io/encrypt: extend 'set_encpolicy' to support v2 policies xfs_io/encrypt: add 'add_enckey' command xfs_io/encrypt: add 'rm_enckey' command
xfs_io/encrypt: add 'enckey_status' command

 io/encrypt.c      | 816 ++++++++++++++++++++++++++++++++++++++++------
 man/man8/xfs_io.8 |  70 +++-
 2 files changed, 771 insertions(+), 115 deletions(-)
Signature · 1 line
2.23.0.444.g18eeb5a265-goog