Skip to content

Fix MemoryRegionSection alignment and comparison

Dr. David Alan Gilbert (git) qemu-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v12 patches 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3memory: Align MemoryRegionSections fieldsinclude/exec/memory.h+1 -10 replies
2/3memory: Provide an equality function for MemoryRegionSectionsinclude/exec/memory.h+12 -00 replies
3/3vhost: Fix memory region section comparisonhw/virtio/vhost.c+7 -20 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] Fix MemoryRegionSection alignment and comparison

From: "Dr. David Alan Gilbert" <[email protected]>

This fixes a symptom I've seen on vhost-user on aarch64 where the daemon would be falsely notified of memory region changes that didn't exist.
The underlying problem was me memcmp'ing MemoryRegionSections even though they had padding in.

(Discovered while getting virtiofs working on aarch)

Dave

v2
Split 1st patch and fix spelling [Philippe's review]

Dr. David Alan Gilbert (3):
memory: Align MemoryRegionSections fields
memory: Provide an equality function for MemoryRegionSections
vhost: Fix memory region section comparison

 hw/virtio/vhost.c     |  9 +++++++--
 include/exec/memory.h | 14 +++++++++++++-
 2 files changed, 20 insertions(+), 3 deletions(-)
Signature · 1 line
2.21.0