Skip to content

un-break nftables on big-endian arches

Florian Westphal netfilter-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesIn review
  2. v14 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3src: fix jumps on bigendian archessrc/datatype.c src/netlink.c+31 -121 reply
2/3src: parser: fix parsing of chain priority and policy on bigendiansrc/parser_bison.y+4 -21 reply
3/3src: mnl: retry when we hit -ENOBUFSsrc/mnl.c+10 -23 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPablo Neira Ayuso
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 nftables 0/3] un-break nftables on big-endian arches

nftables 0.9.1 fails on s390x. Breakage includes:

- "jump foo" is rejected
- chain policies are treated as drop
- chain priority is always set to 0 (same bug though).

Also, last test case reveals problems with receive buffer sizes, these have been fixed as well.

After these changes, all test cases work, except one.
The failure in that test case is caused by timeout rounding errors due to CONFIG_HZ=100, I'll leave that for the time being given HZ=100 is rare noways and the "fix" is to adjust the test case.

Florian Westphal (3):
src: fix jumps on bigendian arches
src: parser: fix parsing of chain priority and policy on bigendian
src: mnl: retry when we hit -ENOBUFS

 datatype.c     |   27 ++++++++++++++++++---------
 mnl.c          |   12 ++++++++++--
 netlink.c      |   16 +++++++++++++---
 parser_bison.y |    6 ++++--
 4 files changed, 45 insertions(+), 16 deletions(-)