Drop CAP_FSETID if client needs to kill setuid/setgid bits
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | virtiofsd: Fix number of padding bits in fuse_file_infocontrib/ | +1 | 2 replies | |
| 2/4 | virtiofsd: Use macros for write_flag parsingcontrib/ | +2 | 1 reply | |
| 3/4 | virtiofsd: Parse flag FUSE_WRITE_KILL_PRIVcontrib/ contrib/ contrib/ | +7 | 1 reply | |
| 4/4 | virtiofsd: Drop CAP_FSETID if client asked for itcontrib/ contrib/ contrib/ | +131 | 3 replies |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Dr. David Alan Gilbert |
|---|---|
| 1/4 | R-b |
| 2/4 | R-b |
| 3/4 | R-b |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Virtio-fs] [PATCH 0/4] Drop CAP_FSETID if client needs to kill setuid/setgid bits
If a file has setuid/setuid bit set and a writer writes to file without having CAP_FSETID capability, kernel clears setuid/setgid bit on file.
pjdfstest test chmod/12.t tests for this. With moving to 5.3 kernel and cache=none this test fails.
Now Miklos has introducd a commit where if client thinks that setuid/setgid bit should be cleared, it sets FUSE_KILL_PRIV flag in fuse_write_in->write_flags. This is an indication to daemon to clear setuid/setgid bit atomically.
So drop CAP_FSETID capability and then proceed with write and that should automatically clear setuid bit.
Vivek Goyal (4):
virtiofsd: Fix number of padding bits in fuse_file_info
virtiofsd: Use macros for write_flag parsing
virtiofsd: Parse flag FUSE_WRITE_KILL_PRIV
virtiofsd: Drop CAP_FSETID if client asked for it
contrib/virtiofsd/Makefile.objs | 2 + contrib/virtiofsd/fuse_common.h | 5 +- contrib/virtiofsd/fuse_kernel.h | 1 + contrib/virtiofsd/fuse_lowlevel.c | 6 +- contrib/virtiofsd/passthrough_ll.c | 127 +++++++++++++++++++++++++++++ contrib/virtiofsd/seccomp.c | 2 + 6 files changed, 140 insertions(+), 3 deletions(-)
Signature · 1 line
2.17.2