Limit the size of vmcore-dmesg.txt to 2G
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 5 repliesIn review
- v12 patches 5 repliesSuperseded
Changes in v2 from the cover letter
[1] split them([patch 1/4] and [patch 2/4]) into a separate patch.
[2] remove a typedef definition for handler.
[3] remove some changes of variable 'fname' and fix its error.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | Cleanup: remove the read_elf_kcore()kexec/ util_lib/ util_lib/ | +4 | 0 replies | |
| 2/4 | Fix an error definition about the variable 'fname'util_lib/ vmcore-dmesg/ | +2 | 0 replies | |
| 3/4 | Cleanup: move it back from util_lib/elf_info.cutil_lib/ util_lib/ vmcore-dmesg/ | +41 | 0 replies | |
| 4/4 | Limit the size of vmcore-dmesg.txt to 2Gvmcore-dmesg/ | +10 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH 0/4 v2] Limit the size of vmcore-dmesg.txt to 2G
[PATCH 1/4] Cleanup: remove the read_elf_kcore()
Here, no need to wrap the read_elf() again, lets invoke it directly. So remove the read_elf_kcore() and clean up redundant code.
[PATCH 2/4] Fix an error definition about the variable 'fname' The variable 'fname' is mistakenly defined two twice, the first definition is in the vmcore-dmesg.c, and the second definition is in the elf_info.c. That is confused and incorrect although it's a static type, because the value of variable 'fname' is not assigned(set) in elf_info.c. Anyway, its value will be always 'null' when printing an error information.
[PATCH 3/4] Cleanup: move it back from util_lib/elf_info.c Some code related to vmcore-dmesg.c is put into the util_lib, which is not very reasonable, so lets move it back and tidy up those code. In addition, that will also help to limit the size of vmcore-dmesg.txt.
[PATCH 4/4] Limit the size of vmcore-dmesg.txt to 2G With some corrupted vmcore files, the vmcore-dmesg.txt file may grow forever till the kdump disk becomes full. Lets limit the size of vmcore-dmesg.txt to avoid such problems.
BTW: I tested this patch series on x86 64 and arm64, it also worked well.
Changes since v1:
[1] split them([patch 1/4] and [patch 2/4]) into a separate patch.
[2] remove a typedef definition for handler.
[3] remove some changes of variable 'fname' and fix its error.
Lianbo Jiang (4):
Cleanup: remove the read_elf_kcore()
Fix an error definition about the variable 'fname'
Cleanup: move it back from util_lib/elf_info.c Limit the size of vmcore-dmesg.txt to 2G
kexec/arch/arm64/kexec-arm64.c | 2 +- util_lib/elf_info.c | 65 ++++++++-------------------------- util_lib/include/elf_info.h | 4 +-- vmcore-dmesg/vmcore-dmesg.c | 42 ++++++++++++++++++++-- 4 files changed, 57 insertions(+), 56 deletions(-)
Signature · 7 lines
2.17.1 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec