Skip to content

arm64: implement KPROBES_ON_FTRACE

Jisheng Zhang linux-arm-kernel linux-doc lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 11 repliesIn review
  2. v61 patch 4 repliesSuperseded
  3. v51 patch 2 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v41 patch5 repliesSuperseded
v31 patch1 replySuperseded
v23 patches14 repliesSuperseded
v14 patches11 repliesSuperseded

Changes in v7 from the cover letter

- add patch1 and patch2
- fix the automatic offset as pointed out by Masami

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3kprobes/ftrace: Use ftrace_location() when [dis]arming probeskernel/kprobes.c+5 -31 reply
2/3ftrace: introduce FTRACE_IP_EXTENSIONinclude/linux/ftrace.h kernel/trace/ftrace.c+5 -12 replies
3/3arm64: implement KPROBES_ON_FTRACEDocumentation/features/debug/kprobes-on-ftrace/arch-support.txt arch/arm64/Kconfig arch/arm64/include/asm/ftrace.h +2 more+82 -18 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchMasami HiramatsuSteven Rostedt (VMware)
1/3A-b
2/3R-b R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/3] arm64: implement KPROBES_ON_FTRACE

KPROBES_ON_FTRACE avoids much of the overhead with regular kprobes as it eliminates the need for a trap, as well as the need to emulate or single-step instructions.

arm64 makes use of GCC -fpatchable-function-entry=2 option to insert two nops. When the function is traced, the first nop will be modified to the LR saver, then the second nop to "bl <ftrace-entry>". We need to allow kprobe on any of these two instructions.

patch1 uses ftrace_location() when [dis]arming probes. patch2 introduces FTRACE_IP_EXTENSION to let ftrace_location() recognise these two instructions as being part of ftrace patch3 implement the KPROBES_ON_FTRACE for arm64

Changes since v6:
- add patch1 and patch2
- fix the automatic offset as pointed out by Masami

Changes since v5:
- rebase v5.5-rc1
- collect Acked-by and Reviewed-by tags

Changes since v4:
- correct reg->pc: probed on foo, then pre_handler see foo+0x4, while

    post_handler see foo+0x8

Changes since v3:
- move kprobe_lookup_name() and arch_kprobe_on_func_entry to ftrace.c since we only want to choose the ftrace entry for KPROBES_ON_FTRACE.
- only choose ftrace entry if (addr && !offset)

Changes since v2:
- remove patch1, make it a single cleanup patch
- remove "This patch" in the change log
- implement arm64's kprobe_lookup_name() and arch_kprobe_on_func_entry instead of patching the common kprobes code

Changes since v1:
- make the kprobes/x86: use instruction_pointer and instruction_pointer_set as patch1
- add Masami's ACK to patch1
- add some description about KPROBES_ON_FTRACE and why we need it on

    arm64

- correct the log before the patch
- remove the consolidation patch, make it as TODO
- only adjust kprobe's addr when KPROBE_FLAG_FTRACE is set
- if KPROBES_ON_FTRACE, ftrace_call_adjust() the kprobe's addr before calling ftrace_location()
- update the kprobes-on-ftrace/arch-support.txt in doc

Jisheng Zhang (2):
ftrace: introduce FTRACE_IP_EXTENSION
arm64: implement KPROBES_ON_FTRACE

Naveen N. Rao (1):
kprobes/ftrace: Use ftrace_location() when [dis]arming probes

 .../debug/kprobes-on-ftrace/arch-support.txt  |  2 +-
 arch/arm64/Kconfig                            |  1 +
 arch/arm64/include/asm/ftrace.h               |  1 +
 arch/arm64/kernel/probes/Makefile             |  1 +
 arch/arm64/kernel/probes/ftrace.c             | 78 +++++++++++++++++++
 include/linux/ftrace.h                        |  4 +
 kernel/kprobes.c                              |  8 +-
 kernel/trace/ftrace.c                         |  2 +-
 8 files changed, 92 insertions(+), 5 deletions(-)
 create mode 100644 arch/arm64/kernel/probes/ftrace.c
Signature · 7 lines
2.24.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel