Skip to content

Dynamic toggling of vlan_filtering for SJA1105 DSA

Vladimir Oltean netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 5 repliesSuperseded
  3. v16 patches 25 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: bridge: Populate the pvid flag in br_vlan_get_infonet/bridge/br_vlan.c+2 -00 replies
2/2net: dsa: tag_8021q: Restore bridge VLANs when enabling vlan_filteringnet/dsa/tag_8021q.c+82 -201 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNikolay AleksandrovVivien Didelot
1/2A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 net-next 0/2] Dynamic toggling of vlan_filtering for SJA1105 DSA

This patchset addresses a limitation in dsa_8021q where this sequence of commands was causing the switch to stop forwarding traffic:

ip link add name br0 type bridge vlan_filtering 0 ip link set dev swp2 master br0
echo 1 > /sys/class/net/br0/bridge/vlan_filtering echo 0 > /sys/class/net/br0/bridge/vlan_filtering

The issue has to do with the VLAN table manipulations that dsa_8021q does without notifying the bridge layer. The solution is to always restore the VLANs that the bridge knows about, when disabling tagging.

Vladimir Oltean (2):
net: bridge: Populate the pvid flag in br_vlan_get_info
net: dsa: tag_8021q: Restore bridge VLANs when enabling vlan_filtering

 net/bridge/br_vlan.c |   2 +
 net/dsa/tag_8021q.c  | 102 ++++++++++++++++++++++++++++++++++---------
 2 files changed, 84 insertions(+), 20 deletions(-)
Signature · 1 line
2.17.1