i915 fixups for lockdep/lockdebugging
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | i915: do not call lockdep_assert_irqs_disabled() on PREEMPT_RTdrivers/ | +6 | 1 reply | |
| 2/3 | i915: convert all irq_locks spinlocks to raw spinlocksdrivers/ drivers/ drivers/ +10 more | +145 | 5 replies | |
| 3/3 | i915: convert uncore lock to raw spinlockdrivers/ drivers/ drivers/ +7 more | +69 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by.
| Patch | Sean V Kelley |
|---|---|
| 1/3 | |
| 2/3 | T-b |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PREEMPT_RT PATCH 0/3] i915 fixups for lockdep/lockdebugging
From: Clark Williams <[email protected]>
The i915 driver was throwing splats on my home test box running v5.2-rt3 when I turned on lockdep and lock debugging configs. This was mainly due to the non-side effects of the spin*_irq*() macros which do nothing to IRQs on PREEMPT_RT. Converting the various irq_lock spinlocks and the uncore lock to be raw_spinlock_t fixes this, although I'm not sure of the performance implications for latency spikes.
Testing was done on an Intel NUC with the following graphics:
00:02.0 VGA compatible controller: Intel Corporation Iris Plus Graphics 650 (rev 06)
Testing on other variants of i915 would be appreciated.
Clark Williams (3):
i915: do not call lockdep_assert_irqs_disabled() on PREEMPT_RT
i915: convert all irq_locks spinlocks to raw spinlocks
i915: convert uncore lock to raw spinlock
drivers/gpu/drm/i915/i915_debugfs.c | 8 +- drivers/gpu/drm/i915/i915_drv.c | 6 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem.c | 4 +- drivers/gpu/drm/i915/i915_irq.c | 154 ++++++++++----------- drivers/gpu/drm/i915/i915_pmu.c | 4 +- drivers/gpu/drm/i915/intel_breadcrumbs.c | 51 +++---- drivers/gpu/drm/i915/intel_display.c | 20 +-- drivers/gpu/drm/i915/intel_engine_cs.c | 4 +- drivers/gpu/drm/i915/intel_engine_types.h | 2 +- drivers/gpu/drm/i915/intel_fifo_underrun.c | 16 +-- drivers/gpu/drm/i915/intel_guc.c | 6 +- drivers/gpu/drm/i915/intel_guc.h | 10 +- drivers/gpu/drm/i915/intel_hotplug.c | 36 ++--- drivers/gpu/drm/i915/intel_pm.c | 8 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 8 +- drivers/gpu/drm/i915/intel_sprite.c | 32 ++--- drivers/gpu/drm/i915/intel_tv.c | 8 +- drivers/gpu/drm/i915/intel_uncore.c | 52 +++---- drivers/gpu/drm/i915/intel_uncore.h | 2 +- drivers/gpu/drm/i915/intel_workarounds.c | 4 +- 21 files changed, 220 insertions(+), 217 deletions(-)
Signature · 1 line
2.21.0