Skip to content

Refactor to expand subslice mask (rev 2)

Stuart Summers intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/i915: Use variable for debugfs device statusdrivers/gpu/drm/i915/i915_debugfs.c+11 -150 replies
2/11drm/i915: Add function to set SSEU info per platformdrivers/gpu/drm/i915/gt/intel_sseu.c drivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/i915_debugfs.c +1 more+28 -280 replies
3/11drm/i915: Add subslice stride runtime parameterdrivers/gpu/drm/i915/gt/intel_sseu.c drivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/i915_query.c+6 -30 replies
4/11drm/i915: Add EU stride runtime parameterdrivers/gpu/drm/i915/gt/intel_sseu.c drivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/i915_query.c +1 more+8 -80 replies
5/11drm/i915: Use local variables for subslice_mask for device infodrivers/gpu/drm/i915/intel_device_info.c+26 -231 reply
6/11drm/i915: Add function to set subslicesdrivers/gpu/drm/i915/gt/intel_sseu.c drivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/intel_device_info.c+20 -72 replies
7/11drm/i915: Use subslice stride to set subslices for a given slicedrivers/gpu/drm/i915/gt/intel_sseu.c drivers/gpu/drm/i915/gt/intel_sseu.h+11 -32 replies
8/11drm/i915: Add function to determine if a slice has a subslicedrivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/intel_device_info.c+20 -50 replies
9/11drm/i915: Refactor instdone loops on new subslice functionsdrivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_types.h drivers/gpu/drm/i915/gt/intel_hangcheck.c +2 more+25 -222 replies
10/11drm/i915: Add new function to copy subslices for a slicedrivers/gpu/drm/i915/i915_debugfs.c+14 -32 replies
11/11drm/i915: Expand subslice maskdrivers/gpu/drm/i915/gt/intel_sseu.c drivers/gpu/drm/i915/gt/intel_sseu.h drivers/gpu/drm/i915/gt/intel_workarounds.c +2 more+40 -102 replies

Reviews trailers per patch

9 of 11 patches have a Reviewed-by or Acked-by.

PatchChris WilsonMika Kuoppala
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11
7/11
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] Refactor to expand subslice mask (rev 2)

Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calculated:
slice * subslice stride + subslice index / 8

Note this is the second iteration of an original patch to implement the same. There are a couple of minor code changes based on changes since the first series was posted. Additionally, the original patch has been split into several smaller patches with more isolated changes based on review feedback in that first series.

Link to the original series:
https://patchwork.freedesktop.org/series/59742/

v2: Fix 32-bit build
v3: Fix typo in haswell sseu info routine and fix SSEU workaround
print
v4: Merge patch to HSW in previous revision with patch to
set subslice_mask for each platform and address feedback from Chris
v5: No changes in code. Resending due to unrelated failures - confirmed
no failures with trybot.
v6: Minor change in intel_workarounds.c to use the new helper function
v7: Split set sublice function into multiple more manageable patches
And add a couple of GEM_BUG_ON checks requested by Chris

Stuart Summers (11):
drm/i915: Use variable for debugfs device status drm/i915: Add function to set SSEU info per platform drm/i915: Add subslice stride runtime parameter drm/i915: Add EU stride runtime parameter
drm/i915: Use local variables for subslice_mask for device info drm/i915: Add function to set subslices
drm/i915: Use subslice stride to set subslices for a given slice drm/i915: Add function to determine if a slice has a subslice drm/i915: Refactor instdone loops on new subslice functions drm/i915: Add new function to copy subslices for a slice drm/i915: Expand subslice mask

 drivers/gpu/drm/i915/gt/intel_engine_cs.c    |   3 +-
 drivers/gpu/drm/i915/gt/intel_engine_types.h |  31 +++--
 drivers/gpu/drm/i915/gt/intel_hangcheck.c    |   3 +-
 drivers/gpu/drm/i915/gt/intel_sseu.c         |  52 +++++++-
 drivers/gpu/drm/i915/gt/intel_sseu.h         |  30 ++++-
 drivers/gpu/drm/i915/gt/intel_workarounds.c  |   5 +-
 drivers/gpu/drm/i915/i915_debugfs.c          |  49 +++++---
 drivers/gpu/drm/i915/i915_gpu_error.c        |   5 +-
 drivers/gpu/drm/i915/i915_query.c            |  10 +-
 drivers/gpu/drm/i915/intel_device_info.c     | 122 +++++++++----------
 10 files changed, 196 insertions(+), 114 deletions(-)
Signature · 6 lines
2.22.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx