Skip to content

Fix bug in nios2 and m68k semihosting

Sandra Loosemore qemu-devel 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesNew
  2. v12 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2target/nios2: Fix bug in semihosted exit handlingtarget/nios2/nios2-semi.c+2 -20 replies
2/2target/m68k: Fix bug in semihosted exit handlingtarget/m68k/m68k-semi.c+2 -20 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLaurent Vivier
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH V2 0/2] Fix bug in nios2 and m68k semihosting

I noticed recently that the exit semihosting call on nios2 was ignoring its parameter and always returning status 0 instead. It turns out the handler was retrieving the value of the wrong register. Since the nios2 semihosting implementation was basically cut-and-pasted from that for m68k, I checked m68k also and it had the same bug. This set of patches fixes both of them.

There are no changes to the actual patches from V1, only more informative commit messages with links to the respective semihosting protocol documents in newlib.

Sandra Loosemore (2):
target/nios2: Fix bug in semihosted exit handling target/m68k: Fix bug in semihosted exit handling

 target/m68k/m68k-semi.c   | 4 ++--
 target/nios2/nios2-semi.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.8.1