Skip to content

bnxt patchset to support device error recovery

Ajit Khaparde dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest15 patches 1 replyIn review
  2. v213 patches 1 replySuperseded
  3. v113 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15net/bnxt: add FW reset HWRM commanddrivers/net/bnxt/hsi_struct_def_dpdk.h+137 -00 replies
2/15net/bnxt: prevent device access when device is in resetdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_cpr.c drivers/net/bnxt/bnxt_ethdev.c +10 more+465 -1530 replies
3/15net/bnxt: handle reset notify async event from FWdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_cpr.c drivers/net/bnxt/bnxt_cpr.h +4 more+215 -220 replies
4/15net/bnxt: inform firmware about IF state changesdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_hwrm.c +1 more+75 -00 replies
5/15net/bnxt: handle fatal event from FW under error conditionsdrivers/net/bnxt/bnxt_cpr.c drivers/net/bnxt/bnxt_cpr.h drivers/net/bnxt/bnxt_ethdev.c+19 -20 replies
6/15net/bnxt: query firmware error recovery capabilitiesdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_hwrm.c +1 more+133 -10 replies
7/15net/bnxt: map status registers for FW health monitoringdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_hwrm.c+59 -10 replies
8/15net/bnxt: advertise error recovery capability and handle async eventdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_cpr.c drivers/net/bnxt/bnxt_cpr.h +2 more+66 -00 replies
9/15net/bnxt: add code for periodic FW health monitoringdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_cpr.c drivers/net/bnxt/bnxt_ethdev.c+113 -00 replies
10/15net/bnxt: add support for FW resetdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_hwrm.c +1 more+131 -10 replies
11/15net/bnxt: add hot firmware upgrade support for Stingraydrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_cpr.c drivers/net/bnxt/bnxt_cpr.h +3 more+54 -00 replies
12/15net/bnxt: reduce verbosity of logsdrivers/net/bnxt/bnxt_cpr.c drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_filter.c +2 more+18 -230 replies
13/15net/bnxt: avoid null pointer dereferencedrivers/net/bnxt/bnxt_ring.c+4 -20 replies
14/15net/bnxt: use BIT macro instead of bit fieldsdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_util.h+44 -390 replies
15/15net/bnxt: add PTP support for Thordrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_hwrm.c +4 more+243 -340 replies

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchSantoshkumar Karanappa RastapurSomnath KoturAjit KhapardeLance RichardsonRahul Gupta
1/15R-b R-b
2/15R-b R-b R-b
3/15R-b R-b
4/15R-b R-b R-b
5/15R-b R-b
6/15R-b
7/15R-b
8/15R-b
9/15R-b R-b
10/15R-b R-b
11/15R-b
12/15R-b R-b R-b
13/15R-b R-b
14/15R-b
15/15R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 00/15] bnxt patchset to support device error recovery

This patchset adds support to monitor the health of the firmware and the underlying device and recover to an operational state in case of error. We can also detect if a FW upgrade is in progress and quiesce all access to the device and recover once FW indicates everything is ready.

Patchset against dpdk-next-net. Please apply.

v2->v3: Some APIs and dev_ops return types has been updated since
v2 was submitted. This version addresses the conflicts on account of that.

Kalesh AP (15):
net/bnxt: add FW reset HWRM command
net/bnxt: prevent device access when device is in reset net/bnxt: handle reset notify async event from FW net/bnxt: inform firmware about IF state changes net/bnxt: handle fatal event from FW under error conditions net/bnxt: query firmware error recovery capabilities net/bnxt: map status registers for FW health monitoring net/bnxt: advertise error recovery capability and handle async event net/bnxt: add code for periodic FW health monitoring net/bnxt: add support for FW reset
net/bnxt: add hot firmware upgrade support for Stingray net/bnxt: reduce verbosity of logs
net/bnxt: avoid null pointer dereference
net/bnxt: use BIT macro instead of bit fields
net/bnxt: add PTP support for Thor

 drivers/net/bnxt/bnxt.h                |  142 +++-
 drivers/net/bnxt/bnxt_cpr.c            |  122 ++-
 drivers/net/bnxt/bnxt_cpr.h            |   19 +
 drivers/net/bnxt/bnxt_ethdev.c         | 1066 ++++++++++++++++++------
 drivers/net/bnxt/bnxt_filter.c         |    2 +-
 drivers/net/bnxt/bnxt_hwrm.c           |  310 ++++++-
 drivers/net/bnxt/bnxt_hwrm.h           |    9 +
 drivers/net/bnxt/bnxt_ring.c           |   45 +-
 drivers/net/bnxt/bnxt_ring.h           |    1 +
 drivers/net/bnxt/bnxt_rxq.c            |   25 +
 drivers/net/bnxt/bnxt_rxr.c            |   59 +-
 drivers/net/bnxt/bnxt_rxr.h            |    2 +
 drivers/net/bnxt/bnxt_stats.c          |   36 +-
 drivers/net/bnxt/bnxt_txq.c            |    7 +
 drivers/net/bnxt/bnxt_txr.c            |   34 +-
 drivers/net/bnxt/bnxt_txr.h            |    2 +
 drivers/net/bnxt/bnxt_util.h           |    4 +
 drivers/net/bnxt/bnxt_vnic.c           |    7 +-
 drivers/net/bnxt/hsi_struct_def_dpdk.h |  242 ++++++
 19 files changed, 1816 insertions(+), 318 deletions(-)
Signature · 1 line
2.20.1 (Apple Git-117)