Skip to content

RCU integration with LPM library

Ruifeng Wang dpdk-dev 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest3 patches 4 repliesIn review
  2. v93 patches 0 repliesSuperseded
  3. v83 patches 2 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v73 patches7 repliesSuperseded
v63 patches0 repliesSuperseded
v53 patches6 repliesSuperseded
v43 patches5 repliesSuperseded
v26 patches8 repliesSuperseded
v1 RFC3 patches4 repliesSuperseded

Changes in v10 from the cover letter

Added missing Acked-by tags.

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3lib/lpm: integrate RCU QSBRdoc/guides/prog_guide/lpm_lib.rst lib/librte_lpm/Makefile lib/librte_lpm/meson.build +3 more+237 -221 reply
2/3test/lpm: add LPM RCU integration functional testsapp/test/test_lpm.c+290 -10 replies
3/3test/lpm: add RCU integration performance testsapp/test/test_lpm_perf.c+489 -31 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchHonnappa NagarahalliRay KinsellaVladimir MedvedkinGavin HuRuifeng Wang
1/3R-b A-b A-b
2/3R-b A-b R-b
3/3A-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v10 thread

Cover letter [dpdk-dev] [PATCH v10 0/3] RCU integration with LPM library

This patchset integrates RCU QSBR support with LPM library.

Resource reclaimation implementation was splitted from the original series, and has already been part of RCU library. Rework the series to base LPM integration on RCU reclaimation APIs.

New API rte_lpm_rcu_qsbr_add is introduced for application to register a RCU variable that LPM library will use. This provides user the handle to enable RCU that integrated in LPM library.

Functional tests and performance tests are added to cover the integration with RCU.

---
v10:
Added missing Acked-by tags.

v9:
Cleared lpm when allocation failed. (David)

v8:
Fixed ABI issue by adding internal LPM control structure. (David) Changed to use RFC5737 address in unit test. (Vladimir)

v7:
Fixed typos in document.

v6:
Remove ALLOW_EXPERIMENTAL_API from rte_lpm.c.

v5:
No default value for reclaim_thd. This allows reclamation triggering with every call. Pass LPM pointer instead of tbl8 as argument of reclaim callback free function. Updated group_idx check at tbl8 allocation.
Use enums instead of defines for different reclamation modes.
RCU QSBR integrated path is inside ALLOW_EXPERIMENTAL_API to avoid ABI change.

v4:
Allow user to configure defer queue: size, reclaim threshold, max entries. Return defer queue handler so user can manually trigger reclaimation. Add blocking mode support. Defer queue will not be created.

Honnappa Nagarahalli (1):
test/lpm: add RCU integration performance tests

Ruifeng Wang (2):
lib/lpm: integrate RCU QSBR
test/lpm: add LPM RCU integration functional tests

 app/test/test_lpm.c                | 291 ++++++++++++++++-
 app/test/test_lpm_perf.c           | 492 ++++++++++++++++++++++++++++-
 doc/guides/prog_guide/lpm_lib.rst  |  32 ++
 lib/librte_lpm/Makefile            |   2 +-
 lib/librte_lpm/meson.build         |   1 +
 lib/librte_lpm/rte_lpm.c           | 165 ++++++++--
 lib/librte_lpm/rte_lpm.h           |  53 ++++
 lib/librte_lpm/rte_lpm_version.map |   6 +
 8 files changed, 1016 insertions(+), 26 deletions(-)
Signature · 1 line
2.17.1