Skip to content

slirp: Fix heap buffer overflow during packet reassembly (CVE-2019-14378)

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Do not reassemble fragments pointing outside of the original payloadsrc/ip_input.c+13 -07 replies
2/2Delay crash when mbufs are corruptedsrc/ip_input.c+9 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/2T-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] slirp: Fix heap buffer overflow during packet reassembly (CVE-2019-14378)

Hi, this is a SLiRP bug, however as QEMU comsumes the library, it is directly concerned, so I'm cross-posting both QEMU and SLiRP lists for a stricter review.

The 2nd patch is a PoC, to give QEMU a chance to shutdown properly if SLiRP internals get corrupted. Simply sent as RFC.

The vulnerability is very well described here:
https://vishnudevtj.github.io/notes/qemu-vm-escape-cve-2019-14378

Exploit (used as reproducer):
https://github.com/vishnudevtj/exploits/blob/master/qemu/CVE-2019-14378/exp.c

Philippe Mathieu-Daudé (2):
Do not reassemble fragments pointing outside of the original payload RFC Delay crash when mbufs are corrupted

 src/ip_input.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
Signature · 1 line
2.20.1