tcg: probe_write() refactorings
Status from this message: Queued to tcg-next.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Changes in v2 from the cover letter
- "tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code" -- Perform only a single !guest_addr_valid(addr) check.
- "tcg: Enforce single page access in probe_write()"
-- Also add the check for CONFIG_USER_ONLY
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | s390x/tcg: Use guest_addr_valid() instead of h2g_valid() in probe_write_access()target/ | +1 | 1 reply | |
| 2/7 | s390x/tcg: Fix length calculation in probe_write_access()target/ | +1 | 1 reply | |
| 3/7 | tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x codeaccel/ include/ target/ | +17 | 1 reply | |
| 4/7 | tcg: Enforce single page access in probe_write()accel/ accel/ | +4 | 1 reply | |
| 5/7 | mips/tcg: Call probe_write() for CONFIG_USER_ONLY as welltarget/ | +3 | 2 replies | |
| 6/7 | hppa/tcg: Call probe_write() also for CONFIG_USER_ONLYtarget/ | +0 | 0 replies | |
| 7/7 | s390x/tcg: Pass a size to probe_write() in do_csst()target/ | +1 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Richard Henderson | Cornelia Huck | Aleksandar Markovic |
|---|---|---|---|
| 1/7 | R-b | R-b | |
| 2/7 | R-b | R-b | |
| 3/7 | R-b | ||
| 4/7 | R-b | ||
| 5/7 | R-b | ||
| 6/7 | R-b | ||
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v2 0/7] tcg: probe_write() refactorings
Based on tcg-next. The last two patches from v1 are now part of "[PATCH 0/6] exec: Cleanup watchpoints" from richard.
Fix and refactore some things around probe_write() in s390x code. Introduce probe_write() for CONFIG_USER_ONLY.
This is the first step of some changes necessary to handle fault-safe access accross multiple pages on s390x. The next step is making probe_write() return an address, similar to tlb_vaddr_to_host(), and introduing probe_read().
v1 -> v2:
- "tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code" -- Perform only a single !guest_addr_valid(addr) check.
- "tcg: Enforce single page access in probe_write()"
-- Also add the check for CONFIG_USER_ONLY
David Hildenbrand (7):
s390x/tcg: Use guest_addr_valid() instead of h2g_valid() in
probe_write_access()
s390x/tcg: Fix length calculation in probe_write_access()
tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code
tcg: Enforce single page access in probe_write() mips/tcg: Call probe_write() for CONFIG_USER_ONLY as well hppa/tcg: Call probe_write() also for CONFIG_USER_ONLY s390x/tcg: Pass a size to probe_write() in do_csst()
accel/tcg/cputlb.c | 2 ++ accel/tcg/user-exec.c | 17 +++++++++++++++++ include/exec/exec-all.h | 4 ++-- target/hppa/op_helper.c | 2 -- target/mips/op_helper.c | 8 +++----- target/s390x/mem_helper.c | 13 ++----------- 6 files changed, 26 insertions(+), 20 deletions(-)
Signature · 1 line
2.21.0