Skip to content

block/file-posix: Reduce xfsctl() use

Max Reitz qemu-devel 1 version Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2block/file-posix: Reduce xfsctl() useblock/file-posix.c+1 -761 reply
2/2iotests: Test reverse sub-cluster qcow2 writestests/qemu-iotests/265 tests/qemu-iotests/265.out tests/qemu-iotests/group+74 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefano GarzarellaJohn Snow
SeriesR-b T-b
1/2T-b R-b
2/2T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] block/file-posix: Reduce xfsctl() use

Hi,

As suggested by Paolo, this series drops xfsctl() calls where we have working fallocate() alternatives. (And thus replaces “block/file-posix:
Fix xfs_write_zeroes()”.)

Unfortunately, we also use xfsctl() to inquire the request alignment for O_DIRECT, and this is the only way we currently have to obtain it without trying. Therefore, I didn’t quite like removing that call, too, so this series doesn’t get rid of xfsctl() completely.

(If we did, we could delete 146 lines instead of these measly 76 here.)

Anyway, dropping xfs_write_zeroes() will also fix the guest corruptions Lukáš has reported (for qcow2, but I think it should be possible to see similar corruptions with raw, although I haven’t investigated that too far).

Max Reitz (2):
block/file-posix: Reduce xfsctl() use
iotests: Test reverse sub-cluster qcow2 writes

 block/file-posix.c         | 77 +-------------------------------------
 tests/qemu-iotests/265     | 67 +++++++++++++++++++++++++++++++++
 tests/qemu-iotests/265.out |  6 +++
 tests/qemu-iotests/group   |  1 +
 4 files changed, 75 insertions(+), 76 deletions(-)
 create mode 100755 tests/qemu-iotests/265
 create mode 100644 tests/qemu-iotests/265.out
Signature · 1 line
2.21.0