Skip to content

Support disabling TCG on ARM (part 2)

Philippe Mathieu-Daudé kvm qemu-arm qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 22 repliesIn review
  2. v319 patches 37 repliesSuperseded
  3. v25 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches9 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12accel/tcg: Add stub for cpu_loop_exit()accel/stubs/tcg-stub.c+5 -02 replies
2/12meson: Allow optional target/${ARCH}/Kconfigmeson.build+7 -15 replies
3/12target/arm: Select SEMIHOSTING if TCG is availabletarget/arm/Kconfig+4 -01 reply
4/12target/arm: Restrict ARMv4 cpus to TCG accelhw/arm/Kconfig+6 -02 replies
5/12target/arm: Restrict ARMv5 cpus to TCG accelhw/arm/Kconfig+11 -00 replies
6/12target/arm: Restrict ARMv6 cpus to TCG accelhw/arm/Kconfig+6 -00 replies
7/12target/arm: Restrict ARMv7 R-profile cpus to TCG accelhw/arm/Kconfig+5 -00 replies
8/12target/arm: Restrict ARMv7 M-profile cpus to TCG acceldefault-configs/arm-softmmu.mak hw/arm/Kconfig+4 -30 replies
9/12target/arm: Make m_helper.c optional via CONFIG_ARM_V7Mtarget/arm/cpu.h target/arm/cpu_tcg.c target/arm/helper.c +2 more+79 -212 replies
10/12target/arm: Do not build TCG objects when TCG is offtarget/arm/meson.build+17 -71 reply
11/12target/arm: Reorder meson.build rulestarget/arm/meson.build+10 -121 reply
12/12.travis.yml: Add a KVM-only Aarch64 job.travis.yml+35 -03 replies

Reviews trailers per patch

5 of 12 patches have a Reviewed-by or Acked-by.

PatchThomas HuthPaolo BonziniRichard Henderson
1/12R-b R-b
2/12A-b
3/12R-b
4/12
5/12
6/12
7/12
8/12
9/12
10/12R-b
11/12R-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/12] Support disabling TCG on ARM (part 2)

Cover from Samuel Ortiz from (part 1) [1]:

This patchset allows for building and running ARM targets with TCG disabled. [...]

The rationale behind this work comes from the NEMU project where we're trying to only support x86 and ARM 64-bit architectures, without including the TCG code base. We can only do so if we can build and run ARM binaries with TCG disabled.

v4 almost 2 years later... [2]:
- Rebased on Meson
- Addressed Richard review comments
- Addressed Claudio review comments

v3 almost 18 months later [3]:
- Rebased
- Addressed Thomas review comments
- Added Travis-CI job to keep building --disable-tcg on ARM

v2 [4]:
- Addressed review comments from Richard and Thomas from v1 [1]

Regards,

Phil.

[1]: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg02451.html
[2]: https://www.mail-archive.com/[email protected]/msg689168.html
[3]: https://www.mail-archive.com/[email protected]/msg641796.html
[4]: https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg05003.html

Green CI:
- https://cirrus-ci.com/build/4572961761918976
- https://gitlab.com/philmd/qemu/-/pipelines/196047779
- https://travis-ci.org/github/philmd/qemu/builds/731370972

Based-on: <[email protected]> "hw/arm: Restrict APEI tables generation to the 'virt' machine"
https://www.mail-archive.com/[email protected]/msg745792.html

Philippe Mathieu-Daudé (10):
accel/tcg: Add stub for cpu_loop_exit()
meson: Allow optional target/${ARCH}/Kconfig target/arm: Select SEMIHOSTING if TCG is available target/arm: Restrict ARMv4 cpus to TCG accel target/arm: Restrict ARMv5 cpus to TCG accel target/arm: Restrict ARMv6 cpus to TCG accel target/arm: Restrict ARMv7 R-profile cpus to TCG accel target/arm: Restrict ARMv7 M-profile cpus to TCG accel target/arm: Reorder meson.build rules .travis.yml: Add a KVM-only Aarch64 job

Samuel Ortiz (1):
target/arm: Do not build TCG objects when TCG is off

Thomas Huth (1):
target/arm: Make m_helper.c optional via CONFIG_ARM_V7M

 default-configs/arm-softmmu.mak |  3 --
 meson.build                     |  8 +++-
 target/arm/cpu.h                | 12 ------
 accel/stubs/tcg-stub.c          |  5 +++
 target/arm/cpu_tcg.c            |  4 +-
 target/arm/helper.c             |  7 ----
 target/arm/m_helper-stub.c      | 73 +++++++++++++++++++++++++++++++++
 .travis.yml                     | 35 ++++++++++++++++
 hw/arm/Kconfig                  | 32 +++++++++++++++
 target/arm/Kconfig              |  4 ++
 target/arm/meson.build          | 40 +++++++++++-------
 11 files changed, 184 insertions(+), 39 deletions(-)
 create mode 100644 target/arm/m_helper-stub.c
 create mode 100644 target/arm/Kconfig
Signature · 1 line
2.26.2