Skip to content

sched: subport level configuration of pipe nodes

Jasvinder Singh dpdk-dev 7 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest15 patches 1 replyApplied
  2. v615 patches 0 repliesSuperseded
  3. v515 patches 2 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v417 patches2 repliesSuperseded
v315 patches0 repliesSuperseded
v215 patches2 repliesSuperseded
v115 patches0 repliesSuperseded

Changes in v7 from the cover letter

- rebase on latest dpdk master
- fix build issue with clang

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/15sched: add pipe config params to subport structlib/librte_sched/Makefile lib/librte_sched/meson.build lib/librte_sched/rte_sched.h+65 -310 replies
2/15sched: modify internal structs for config flexibilitylib/librte_sched/rte_sched.c+78 -280 replies
3/15sched: remove pipe params config from port levellib/librte_sched/rte_sched.c+71 -1830 replies
4/15sched: add pipe config to subport levellib/librte_sched/rte_sched.c+332 -560 replies
5/15sched: modify pipe functions for config flexibilitylib/librte_sched/rte_sched.c lib/librte_sched/rte_sched.h lib/librte_sched/rte_sched_version.map+76 -360 replies
6/15sched: modify pkt enqueue for config flexibilitylib/librte_sched/rte_sched.c+178 -1090 replies
7/15sched: update memory compute to support flexiblitylib/librte_sched/rte_sched.c lib/librte_sched/rte_sched.h+34 -740 replies
8/15sched: update grinder functions for config flexibilitylib/librte_sched/rte_sched.c+106 -1170 replies
9/15sched: update pkt dequeue for flexible configlib/librte_sched/rte_sched.c+40 -110 replies
10/15sched: update queue stats read for config flexibilitylib/librte_sched/rte_sched.c+15 -30 replies
11/15test/sched: modify tests for subport config flexibilityapp/test/test_sched.c+18 -170 replies
12/15net/softnic: add subport config flexibility to TMdrivers/net/softnic/rte_eth_softnic_tm.c+28 -260 replies
13/15ip_pipeline: add subport config flexibility to TMexamples/ip_pipeline/cli.c examples/ip_pipeline/tmgr.c examples/ip_pipeline/tmgr.h+51 -520 replies
14/15examples/qos_sched: add subport configuration flexibilityexamples/qos_sched/app_thread.c examples/qos_sched/cfg_file.c examples/qos_sched/init.c +4 more+203 -1550 replies
15/15sched: remove redundant codedoc/guides/rel_notes/release_19_11.rst lib/librte_sched/rte_sched.c lib/librte_sched/rte_sched.h+7 -640 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [dpdk-dev] [PATCH v7 00/15] sched: subport level configuration of pipe nodes

This patchset refactors the dpdk qos sched library to allow subport level configuration flexibility of the pipe nodes.

Currently, all parameters for the pipe nodes (subscribers) configuration are part of the port level structure which forces all groups of subscribers (pipes) in different subports to have similar configurations in terms of their number, queue sizes, traffic-classes, etc.

The new implementation moves pipe nodes configuration parameters from port level to subport level structure. This allows different subports of the same port to have different configuration for the pipe nodes, for examples- number of pipes, queue sizes, pipe profiles, etc.

In order to keep the implementation complexity under control, all pipes within the same subport share the same configuration for queue sizes.

v7:
- rebase on latest dpdk master
- fix build issue with clang

v6:
- fix build issue with patchset

v5:
- remove patches on 64-bit values support, sent separately

v4:
- remove deprecation note
- rebase on current dpdk head
- add 64-bit values support

v3:
- improve doxygen comments

v2:
- fix qsize parsing in sample application
- fix checkpatch warnings

Jasvinder Singh (15):
sched: add pipe config params to subport struct
sched: modify internal structs for config flexibility
sched: remove pipe params config from port level
sched: add pipe config to subport level
sched: modify pipe functions for config flexibility
sched: modify pkt enqueue for config flexibility
sched: update memory compute to support flexiblity
sched: update grinder functions for config flexibility
sched: update pkt dequeue for flexible config
sched: update queue stats read for config flexibility test/sched: modify tests for subport config flexibility net/softnic: add subport config flexibility to TM
ip_pipeline: add subport config flexibility to TM examples/qos_sched: add subport configuration flexibility
sched: remove redundant code

 app/test/test_sched.c                    |   35 +-
 doc/guides/rel_notes/release_19_11.rst   |    7 +-
 drivers/net/softnic/rte_eth_softnic_tm.c |   54 +-
 examples/ip_pipeline/cli.c               |   71 +-
 examples/ip_pipeline/tmgr.c              |   25 +-
 examples/ip_pipeline/tmgr.h              |    7 +-
 examples/qos_sched/app_thread.c          |   20 +-
 examples/qos_sched/cfg_file.c            |  229 ++--
 examples/qos_sched/init.c                |   54 +-
 examples/qos_sched/main.h                |    1 +
 examples/qos_sched/profile.cfg           |    5 +-
 examples/qos_sched/profile_ov.cfg        |    5 +-
 examples/qos_sched/stats.c               |   44 +-
 lib/librte_sched/Makefile                |    2 +-
 lib/librte_sched/meson.build             |    2 +-
 lib/librte_sched/rte_sched.c             | 1394 +++++++++++++---------
 lib/librte_sched/rte_sched.h             |  129 +-
 lib/librte_sched/rte_sched_version.map   |    2 +-
 18 files changed, 1213 insertions(+), 873 deletions(-)
Signature · 1 line
2.21.0