Skip to content

Remove implicit lock knowledge from lo_destroy

Dr. David Alan Gilbert (git) virtio-fs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2virtiofsd: Rename unref_inode to indicate lockcontrib/virtiofsd/passthrough_ll.c+13 -130 replies
2/2virtiofsd: Convert lo_destroy to take the lo->mutex lock itselfcontrib/virtiofsd/passthrough_ll.c+15 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Virtio-fs] [PATCH 0/2] Remove implicit lock knowledge from lo_destroy

From: "Dr. David Alan Gilbert" <[email protected]>

This comes from a comment by Vivek on an earlier review of lo_destroy fixes. In this pair I split unref_inode into a locked and unlocked version and use the unlocked version in lo_destroy with an outer lock. Note this does move the lo_inode_put inside the lock, but I don't think that's an issue.

Dr. David Alan Gilbert (2):
virtiofsd: Rename unref_inode to indicate lock
virtiofsd: Convert lo_destroy to take the lo->mutex lock itself

 contrib/virtiofsd/passthrough_ll.c | 45 ++++++++++++++++--------------
 1 file changed, 24 insertions(+), 21 deletions(-)
Signature · 1 line
2.21.0