Refactor to expand subslice mask (rev 2)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | drm/i915: Use variable for debugfs device statusdrivers/ | +11 | 0 replies | |
| 2/11 | drm/i915: Add function to set SSEU info per platformdrivers/ drivers/ drivers/ +1 more | +28 | 0 replies | |
| 3/11 | drm/i915: Add subslice stride runtime parameterdrivers/ drivers/ drivers/ | +8 | 0 replies | |
| 4/11 | drm/i915: Add EU stride runtime parameterdrivers/ drivers/ drivers/ +1 more | +11 | 0 replies | |
| 5/11 | drm/i915: Use local variables for subslice_mask for device infodrivers/ | +26 | 0 replies | |
| 6/11 | drm/i915: Add function to set subslicesdrivers/ drivers/ drivers/ | +20 | 0 replies | |
| 7/11 | drm/i915: Use subslice stride to set subslices for a given slicedrivers/ drivers/ | +5 | 1 reply | |
| 8/11 | drm/i915: Add function to determine if a slice has a subslicedrivers/ drivers/ | +20 | 0 replies | |
| 9/11 | drm/i915: Refactor instdone loops on new subslice functionsdrivers/ drivers/ drivers/ +2 more | +24 | 0 replies | |
| 10/11 | drm/i915: Add new function to copy subslices for a slicedrivers/ | +14 | 0 replies | |
| 11/11 | drm/i915: Expand subslice maskdrivers/ drivers/ drivers/ +2 more | +28 | 0 replies |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Chris Wilson | Mika Kuoppala |
|---|---|---|
| 1/11 | R-b | |
| 2/11 | R-b | |
| 3/11 | R-b | |
| 4/11 | R-b | |
| 5/11 | R-b | |
| 6/11 | R-b | |
| 7/11 | R-b | |
| 8/11 | R-b | |
| 9/11 | R-b | |
| 10/11 | R-b | |
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/11] Refactor to expand subslice mask (rev 2)
Better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calculated:
slice * subslice stride + subslice index / 8
Note this is the second iteration of an original patch to implement the same. There are a couple of minor code changes based on changes since the first series was posted. Additionally, the original patch has been split into several smaller patches with more isolated changes based on review feedback in that first series.
Link to the original series:
https://patchwork.freedesktop.org/series/59742/
v2: Fix 32-bit build
v3: Fix typo in haswell sseu info routine and fix SSEU workaround
print
v4: Merge patch to HSW in previous revision with patch to
set subslice_mask for each platform and address feedback from Chris
v5: No changes in code. Resending due to unrelated failures - confirmed
no failures with trybot.
v6: Minor change in intel_workarounds.c to use the new helper function
v7: Split set sublice function into multiple more manageable patches
And add a couple of GEM_BUG_ON checks requested by Chris
v8: Address new comments from Chris including adding/moving
a couple of ss/eu_stride checks to those previously reviewed patches earlier in this series
v9: Use memcpy to set subslices (Chris)
Stuart Summers (11):
drm/i915: Use variable for debugfs device status drm/i915: Add function to set SSEU info per platform drm/i915: Add subslice stride runtime parameter drm/i915: Add EU stride runtime parameter
drm/i915: Use local variables for subslice_mask for device info drm/i915: Add function to set subslices
drm/i915: Use subslice stride to set subslices for a given slice drm/i915: Add function to determine if a slice has a subslice drm/i915: Refactor instdone loops on new subslice functions drm/i915: Add new function to copy subslices for a slice drm/i915: Expand subslice mask
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 3 +- drivers/gpu/drm/i915/gt/intel_engine_types.h | 30 +++-- drivers/gpu/drm/i915/gt/intel_hangcheck.c | 3 +- drivers/gpu/drm/i915/gt/intel_sseu.c | 37 +++++- drivers/gpu/drm/i915/gt/intel_sseu.h | 32 ++++- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +- drivers/gpu/drm/i915/i915_debugfs.c | 49 +++++--- drivers/gpu/drm/i915/i915_gpu_error.c | 5 +- drivers/gpu/drm/i915/i915_query.c | 10 +- drivers/gpu/drm/i915/intel_device_info.c | 122 +++++++++---------- 10 files changed, 182 insertions(+), 114 deletions(-)
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx