Skip to content

media: imx: Fix subdev unregister/register issues

Steve Longerbeam linux-arm-kernel linux-media lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Add missing local var ic_priv in prp_registered() in first patch.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2media: imx: Move capture device init to registereddrivers/staging/media/imx/imx-ic-prpencvf.c drivers/staging/media/imx/imx-media-csi.c drivers/staging/media/imx/imx7-media-csi.c+38 -290 replies
2/2media: imx: Move pads init to probedrivers/staging/media/imx/imx-ic-prp.c drivers/staging/media/imx/imx-ic-prpencvf.c drivers/staging/media/imx/imx-media-capture.c +5 more+81 -1030 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRui Miguel Silva
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] media: imx: Fix subdev unregister/register issues

If the media device module is removed and re-probed without also removing and re-probing the subdevice modules, .unregister() and .register() ops are called on the subdevices without the subdevice drivers being removed and re-probed. This creates two problems:

- the CSI and PRPENCVF subdevices attempt to register a stale video capture device resulting in the kobject "tried to init an initialized object" backtrace.

- pad graph objects are added to the media device pad list twice, resulting in list corruption on the pad list.

The following two patches fix those issues.

History:
v2:
- Add missing local var ic_priv in prp_registered() in first patch.

Steve Longerbeam (2):
media: imx: Move capture device init to registered
media: imx: Move pads init to probe

 drivers/staging/media/imx/imx-ic-prp.c        | 25 ++++-----
 drivers/staging/media/imx/imx-ic-prpencvf.c   | 51 ++++++++++---------
 drivers/staging/media/imx/imx-media-capture.c | 15 +++---
 drivers/staging/media/imx/imx-media-csi.c     | 35 +++++++------
 drivers/staging/media/imx/imx-media-vdic.c    | 27 ++++------
 drivers/staging/media/imx/imx6-mipi-csi2.c    | 27 +++++-----
 drivers/staging/media/imx/imx7-media-csi.c    | 38 +++++++-------
 drivers/staging/media/imx/imx7-mipi-csis.c    | 23 +++------
 8 files changed, 114 insertions(+), 127 deletions(-)
Signature · 1 line
2.17.1