Skip to content

Simplify DSA handling of VLAN subinterface offload

Vladimir Oltean netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: dsa: Advertise the VLAN offload netdev ability only if switch supports itnet/dsa/slave.c+6 -90 replies
2/2net: dsa: sja1105: Clear VLAN filtering offload netdev featuredrivers/net/dsa/sja1105/sja1105_main.c+16 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/2] Simplify DSA handling of VLAN subinterface offload

Depends on Vivien Didelot's patchset:
https://patchwork.ozlabs.org/project/netdev/list/?series=127197&state=*

This patchset removes a few strange-looking guards for -EOPNOTSUPP in dsa_slave_vlan_rx_add_vid and dsa_slave_vlan_rx_kill_vid, making that code path no longer possible.

It also disables the code path for the sja1105 driver, which does support editing the VLAN table, but not hardware-accelerated VLAN sub-interfaces, therefore the check in the DSA core would be wrong. There was no better DSA callback to do this than .port_enable, i.e. at ndo_open time.

Vladimir Oltean (2):
net: dsa: Advertise the VLAN offload netdev ability only if switch
supports it
net: dsa: sja1105: Clear VLAN filtering offload netdev feature

 drivers/net/dsa/sja1105/sja1105_main.c | 16 ++++++++++++++++
 net/dsa/slave.c                        | 15 ++++++---------
 2 files changed, 22 insertions(+), 9 deletions(-)
Signature · 1 line
2.17.1