Skip to content

RFC crypto/luks: preparation for encryption key managment

Maxim Levitsky qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest13 patches 16 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13introduce g_autowipeinclude/autowipe.h+52 -03 replies
2/13block-crypto: misc refactoringblock/crypto.c+6 -60 replies
3/13qcrypto-luks: rename some fields in QCryptoBlockLUKSHeadercrypto/block-luks.c+47 -441 reply
4/13qcrypto-luks: don't overwrite cipher_mode in headercrypto/block-luks.c+6 -31 reply
5/13qcrypto-luks: simplify masterkey and masterkey lengthcrypto/block-luks.c+21 -231 reply
6/13qcrypto-block: pass keyslot index rather that pointer to the keyslotcrypto/block-luks.c+3 -31 reply
7/13qcrypto-luks: use the parsed encryption settings in QCryptoBlockLUKScrypto/block-luks.c+79 -901 reply
8/13qcrypto-luks: extract store and load headercrypto/block-luks.c+102 -641 reply
9/13qcrypto-block: extract check and parse headercrypto/block-luks.c+146 -1082 replies
10/13qcrypto-luks: refactoring: extract store key functioncrypto/block-luks.c+184 -1261 reply
11/13qcrypto-luks: refactoring: simplify the math used for keyslot locationscrypto/block-luks.c+41 -232 replies
12/13qcrypto-luks: use g_autowipecrypto/block-luks.c+22 -390 replies
13/13qcrypto-luks: implement more rigorous header checkingcrypto/block-luks.c+44 -22 replies

Reviews trailers per patch

7 of 13 patches have a Reviewed-by or Acked-by.

PatchDaniel P. Berrangé
1/13
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13
9/13
10/13
11/13R-b
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/13] RFC crypto/luks: preparation for encryption key managment

Hi!

This patch series is the refactoring/preparation part of the former patch series I had sent which adds support for luks key management.

I tried my best to address all the comments that were given during the review, and I would like to use that opportunity to thanks again for the review I was given.

Best regards,
Maxim Levitsky

Maxim Levitsky (13):
introduce g_autowipe
block-crypto: misc refactoring
qcrypto-luks: rename some fields in QCryptoBlockLUKSHeader
qcrypto-luks: don't overwrite cipher_mode in header
qcrypto-luks: simplify masterkey and masterkey length
qcrypto-block: pass keyslot index rather that pointer to the keyslot
qcrypto-luks: use the parsed encryption settings in QCryptoBlockLUKS
qcrypto-luks: extract store and load header
qcrypto-block: extract check and parse header
qcrypto-luks: refactoring: extract store key function
qcrypto-luks: refactoring: simplify the math used for keyslot
locations
qcrypto-luks: use g_autowipe
qcrypto-luks: implement more rigorous header checking

 block/crypto.c      |   12 +-
 crypto/block-luks.c | 1046 +++++++++++++++++++++++++------------------
 include/autowipe.h  |   52 +++
 3 files changed, 666 insertions(+), 444 deletions(-)
 create mode 100644 include/autowipe.h
Signature · 1 line
2.17.2