Skip to content

panfrost: Locking and runtime PM fixes

Rob Herring dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest8 patches 16 repliesIn review

Changes in v3 from the cover letter

- Applied patches 1, 4, 5, and 6
- Fix race in job timeout handling with ISR
- Remove some no longer needed locks
- Fix panfrost_mmu_unmap when autosuspend delay is > 0
- Disable AS MMU when freeing page tables

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/panfrost: Rework runtime PM initializationdrivers/gpu/drm/panfrost/panfrost_device.c drivers/gpu/drm/panfrost/panfrost_drv.c+6 -132 replies
2/8drm/panfrost: Hold runtime PM reference until jobs completedrivers/gpu/drm/panfrost/panfrost_job.c+28 -111 reply
3/8drm/panfrost: Remove unnecessary mmu->lock mutexdrivers/gpu/drm/panfrost/panfrost_device.h drivers/gpu/drm/panfrost/panfrost_mmu.c+0 -102 replies
4/8drm/panfrost: Rework page table flushing and runtime PM interactiondrivers/gpu/drm/panfrost/panfrost_mmu.c+18 -202 replies
5/8drm/panfrost: Split mmu_hw_do_operation into locked and unlocked versiondrivers/gpu/drm/panfrost/panfrost_mmu.c+13 -131 reply
6/8drm/panfrost: Add cache/TLB flush before switching address spacedrivers/gpu/drm/panfrost/panfrost_mmu.c+2 -02 replies
7/8drm/panfrost: Flush and disable address space when freeing page tablesdrivers/gpu/drm/panfrost/panfrost_mmu.c+9 -74 replies
8/8drm/panfrost: Remove unnecessary hwaccess_lock spin_lockdrivers/gpu/drm/panfrost/panfrost_device.c drivers/gpu/drm/panfrost/panfrost_device.h drivers/gpu/drm/panfrost/panfrost_job.c+0 -71 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchAlyssa RosenzweigRobin MurphySteven Price
1/8A-b R-b R-b
2/8R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b
6/8R-b R-b
7/8R-b R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/8] panfrost: Locking and runtime PM fixes

With further testing of recent changes with lockdep identified some locking issues. Avoiding lockdep issues means we need to avoid some locks in panfrost_mmu_unmap which in turn means avoiding runtime PM resume. In the process of re-working runtime PM several runtime PM and locking clean-ups have been identified.

v3:
- Applied patches 1, 4, 5, and 6
- Fix race in job timeout handling with ISR
- Remove some no longer needed locks
- Fix panfrost_mmu_unmap when autosuspend delay is > 0
- Disable AS MMU when freeing page tables

v2:
- Drop already applied 'drm/panfrost: Fix sleeping while atomic in panfrost_gem_open'
- Runtime PM clean-ups
- Keep panfrost_gem_purge and use mutex_trylock there
- Rework panfrost_mmu_unmap runtime PM

Rob

Rob Herring (8):
drm/panfrost: Rework runtime PM initialization drm/panfrost: Hold runtime PM reference until jobs complete drm/panfrost: Remove unnecessary mmu->lock mutex drm/panfrost: Rework page table flushing and runtime PM interaction drm/panfrost: Split mmu_hw_do_operation into locked and unlocked
version
drm/panfrost: Add cache/TLB flush before switching address space drm/panfrost: Flush and disable address space when freeing page tables drm/panfrost: Remove unnecessary hwaccess_lock spin_lock

 drivers/gpu/drm/panfrost/panfrost_device.c | 10 ---
 drivers/gpu/drm/panfrost/panfrost_device.h |  3 -
 drivers/gpu/drm/panfrost/panfrost_drv.c    | 10 ++-
 drivers/gpu/drm/panfrost/panfrost_job.c    | 43 ++++++----
 drivers/gpu/drm/panfrost/panfrost_mmu.c    | 91 ++++++++++------------
 5 files changed, 76 insertions(+), 81 deletions(-)

--
2.20.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel