panfrost: Locking and runtime PM fixes
Get series with b4
b4 am [email protected]Versions newest first
- v3 Latest8 patches 16 repliesIn review
Changes in v3 from the cover letter
- Applied patches 1, 4, 5, and 6
- Fix race in job timeout handling with ISR
- Remove some no longer needed locks
- Fix panfrost_mmu_unmap when autosuspend delay is > 0
- Disable AS MMU when freeing page tables
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | drm/panfrost: Rework runtime PM initializationdrivers/ drivers/ | +6 | 2 replies | |
| 2/8 | drm/panfrost: Hold runtime PM reference until jobs completedrivers/ | +28 | 1 reply | |
| 3/8 | drm/panfrost: Remove unnecessary mmu->lock mutexdrivers/ drivers/ | +0 | 2 replies | |
| 4/8 | drm/panfrost: Rework page table flushing and runtime PM interactiondrivers/ | +18 | 2 replies | |
| 5/8 | drm/panfrost: Split mmu_hw_do_operation into locked and unlocked versiondrivers/ | +13 | 1 reply | |
| 6/8 | drm/panfrost: Add cache/TLB flush before switching address spacedrivers/ | +2 | 2 replies | |
| 7/8 | drm/panfrost: Flush and disable address space when freeing page tablesdrivers/ | +9 | 4 replies | |
| 8/8 | drm/panfrost: Remove unnecessary hwaccess_lock spin_lockdrivers/ drivers/ drivers/ | +0 | 1 reply |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Alyssa Rosenzweig | Robin Murphy | Steven Price |
|---|---|---|---|
| 1/8 | A-b | R-b | R-b |
| 2/8 | R-b | ||
| 3/8 | R-b | R-b | |
| 4/8 | R-b | R-b | |
| 5/8 | R-b | ||
| 6/8 | R-b | R-b | |
| 7/8 | R-b | R-b | |
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/8] panfrost: Locking and runtime PM fixes
With further testing of recent changes with lockdep identified some locking issues. Avoiding lockdep issues means we need to avoid some locks in panfrost_mmu_unmap which in turn means avoiding runtime PM resume. In the process of re-working runtime PM several runtime PM and locking clean-ups have been identified.
v3:
- Applied patches 1, 4, 5, and 6
- Fix race in job timeout handling with ISR
- Remove some no longer needed locks
- Fix panfrost_mmu_unmap when autosuspend delay is > 0
- Disable AS MMU when freeing page tables
v2:
- Drop already applied 'drm/panfrost: Fix sleeping while atomic in panfrost_gem_open'
- Runtime PM clean-ups
- Keep panfrost_gem_purge and use mutex_trylock there
- Rework panfrost_mmu_unmap runtime PM
Rob
Rob Herring (8):
drm/panfrost: Rework runtime PM initialization drm/panfrost: Hold runtime PM reference until jobs complete drm/panfrost: Remove unnecessary mmu->lock mutex drm/panfrost: Rework page table flushing and runtime PM interaction drm/panfrost: Split mmu_hw_do_operation into locked and unlocked
version
drm/panfrost: Add cache/TLB flush before switching address space drm/panfrost: Flush and disable address space when freeing page tables drm/panfrost: Remove unnecessary hwaccess_lock spin_lock
drivers/gpu/drm/panfrost/panfrost_device.c | 10 --- drivers/gpu/drm/panfrost/panfrost_device.h | 3 - drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++- drivers/gpu/drm/panfrost/panfrost_job.c | 43 ++++++---- drivers/gpu/drm/panfrost/panfrost_mmu.c | 91 ++++++++++------------ 5 files changed, 76 insertions(+), 81 deletions(-)
--
2.20.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel