Skip to content

Cleanup btrfs_find_name_in* functions

Nikolay Borisov linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: Make btrfs_find_name_in_backref return btrfs_inode_ref structfs/btrfs/ctree.h fs/btrfs/inode-item.c fs/btrfs/tree-log.c+19 -202 replies
2/3btrfs: Make btrfs_find_name_in_ext_backref return struct btrfs_inode_extreffs/btrfs/ctree.h fs/btrfs/inode-item.c fs/btrfs/tree-log.c+20 -281 reply
3/3btrfs: Use btrfs_find_name_in_backref in backref_in_logfs/btrfs/tree-log.c+16 -411 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Cleanup btrfs_find_name_in* functions

This series cleans up the calling convention of the 2 function used to search the INODE_REF items for the presence of particular name. Namely, I switch the 2 functions to directly return a struct btrfs_inode_(ext)?ref. This reduces the number of parameters when calling the functions.

While doing the aforementioned cleanup I stumbled upon backref_in_log which was opencoding btrfs_find_name_in_backref hence I just refactored the function.

This series survived xfstest.

Nikolay Borisov (3):
btrfs: Make btrfs_find_name_in_backref return btrfs_inode_ref struct
btrfs: Make btrfs_find_name_in_ext_backref return struct
btrfs_inode_extref
btrfs: Use btrfs_find_name_in_backref in backref_in_log

 fs/btrfs/ctree.h      | 15 +++++-----
 fs/btrfs/inode-item.c | 62 ++++++++++++++++++-----------------------
 fs/btrfs/tree-log.c   | 65 +++++++++++++------------------------------
 3 files changed, 54 insertions(+), 88 deletions(-)
Signature · 1 line
2.17.1