Skip to content

Support "shell quoting" in the Record dialog

Yordan Karadzhov (VMware) linux-trace-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 4 repliesIn review
  2. v11 patch 8 repliesSuperseded

Changes in v2 from the cover letter

- Handling of multiple quotations and multi-line command arguments in

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3kernel-shark: Provide parsing for quotation marks in Record command linekernel-shark/src/KsCaptureDialog.cpp kernel-shark/src/KsUtils.cpp kernel-shark/src/KsUtils.hpp+50 -32 replies
2/3kernel-shark: give more space to the command field of the Record dialogkernel-shark/src/KsCaptureDialog.cpp kernel-shark/src/KsCaptureDialog.hpp+43 -40 replies
3/3kernel-shark: Add quotation marks parsing example/testkernel-shark/examples/CMakeLists.txt kernel-shark/examples/cmd_split.cpp+56 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] Support "shell quoting" in the Record dialog

A patch set implementing the improvements suggested here:
https://bugzilla.kernel.org/show_bug.cgi?id=204679

v2 changes:
- Handling of multiple quotations and multi-line command arguments in

    patch 1/3.

- Patches 2/3 and 3/3 are new.

Yordan Karadzhov (VMware) (3):
kernel-shark: Provide parsing for quotation marks in Record command
line
kernel-shark: give more space to the command field of the Record
dialog
kernel-shark: Add quotation marks parsing example/test

 kernel-shark/examples/CMakeLists.txt |  4 +++
 kernel-shark/examples/cmd_split.cpp  | 52 ++++++++++++++++++++++++++++
 kernel-shark/src/KsCaptureDialog.cpp | 37 +++++++++++++++++---
 kernel-shark/src/KsCaptureDialog.hpp | 18 +++++++++-
 kernel-shark/src/KsUtils.cpp         | 41 ++++++++++++++++++++++
 kernel-shark/src/KsUtils.hpp         |  2 ++
 6 files changed, 148 insertions(+), 6 deletions(-)
 create mode 100644 kernel-shark/examples/cmd_split.cpp
Signature · 1 line
2.20.1