Skip to content

adapt SOF to use snd-hda-codec-hdmi

Kai Vehmanen alsa-devel 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest9 patches 11 repliesIn review
  2. v79 patches 6 repliesSuperseded
  3. v69 patches 8 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v59 patches2 repliesSuperseded
v49 patches7 repliesSuperseded
v310 patches10 repliesSuperseded
v2 RFC6 patches4 repliesSuperseded
v1 RFC7 patches7 repliesSuperseded

Changes in v8 from the cover letter

- rebased on top of Mark's for-next (50484b6a523a)
- addressed Takashi's review comment to patch 5
- addressed two sparse warnings in patch 3 reported by kbuild test robot <[email protected]>
- fixed itnull.cocci warning in patch 3 reported by Julia Lawall <[email protected]> and kbuild test robot <[email protected]>

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9ALSA: hda/hdmi - implement mst_no_extra_pcms flaginclude/sound/hda_codec.h sound/pci/hda/patch_hdmi.c+15 -51 reply
2/9ASoC: hdac_hda: add support for HDMI/DP as a HDA codecsound/soc/codecs/hdac_hda.c sound/soc/codecs/hdac_hda.h+114 -131 reply
3/9ASoC: Intel: skl-hda-dsp-generic: use snd-hda-codec-hdmiinclude/sound/soc-acpi.h sound/soc/intel/boards/Makefile sound/soc/intel/boards/hda_dsp_common.c +4 more+150 -11 reply
4/9ASoC: Intel: skl-hda-dsp-generic: fix include guard namesound/soc/intel/boards/skl_hda_dsp_common.h+2 -21 reply
5/9ASoC: SOF: Intel: add support for snd-hda-codec-hdmisound/soc/sof/intel/Kconfig sound/soc/sof/intel/hda-codec.c sound/soc/sof/intel/hda.c +1 more+38 -61 reply
6/9ASoC: Intel: bxt-da7219-max98357a: common hdmi codec supportsound/soc/intel/boards/Makefile sound/soc/intel/boards/bxt_da7219_max98357a.c+12 -11 reply
7/9ASoC: Intel: glk_rt5682_max98357a: common hdmi codec supportsound/soc/intel/boards/Makefile sound/soc/intel/boards/glk_rt5682_max98357a.c+12 -11 reply
8/9ASoC: intel: sof_rt5682: common hdmi codec supportsound/soc/intel/boards/Makefile sound/soc/intel/boards/sof_rt5682.c+12 -11 reply
9/9ASoC: Intel: bxt_rt298: common hdmi codec supportsound/soc/intel/boards/Makefile sound/soc/intel/boards/bxt_rt298.c+12 -11 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTakashi IwaiPierre-Louis Bossart
SeriesR-b R-b
1/9R-b R-b R-b R-b
2/9R-b R-b
3/9R-b R-b
4/9R-b R-b R-b R-b
5/9R-b R-b
6/9R-b R-b
7/9R-b R-b
8/9R-b R-b
9/9R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [alsa-devel] [PATCH v8 0/9] adapt SOF to use snd-hda-codec-hdmi

Hey,
here's the 8th round for this series that adapts SOF to use snd-hda-codec-hdmi (patch_hdmi.c) codec driver instead of hdac_hdmi (soc/codecs/hdac_hdmi.c). The primary goal is to unify the HDMI codec implementation between DSP and non-DSP HDA configurations, offer same interface to user-space and reduce maintenance load for all.

Intended to go in via Mark's ASoC tree.

v8 changes:
- rebased on top of Mark's for-next (50484b6a523a)
- addressed Takashi's review comment to patch 5
- addressed two sparse warnings in patch 3 reported by kbuild test robot <[email protected]>
- fixed itnull.cocci warning in patch 3 reported by Julia Lawall <[email protected]> and kbuild test robot <[email protected]>

Feature and testing info:
- Tested on multiple Intel platforms supported by SOF.
- Tested with ALSA console tools as well as with Pulseaudio.
- requires Pulseaudio 12.x or newer, see
https://lists.freedesktop.org/archives/pulseaudio-discuss/2019-August/031358.html
- HDMI, DP, DP-MST with multi-monitor use-scenarios work ok.
- New feature for SOF: ELD /proc fs works just like in DSP-less mode.
- New feature for SOF: jack detection works out-of-the-box with Pulseaudio (no need for card specific UCM for HDMI)

Kai Vehmanen (9):
ALSA: hda/hdmi - implement mst_no_extra_pcms flag
ASoC: hdac_hda: add support for HDMI/DP as a HDA codec
ASoC: Intel: skl-hda-dsp-generic: use snd-hda-codec-hdmi
ASoC: Intel: skl-hda-dsp-generic: fix include guard name
ASoC: SOF: Intel: add support for snd-hda-codec-hdmi
ASoC: Intel: bxt-da7219-max98357a: common hdmi codec support
ASoC: Intel: glk_rt5682_max98357a: common hdmi codec support
ASoC: intel: sof_rt5682: common hdmi codec support
ASoC: Intel: bxt_rt298: common hdmi codec support

 include/sound/hda_codec.h                     |   1 +
 include/sound/soc-acpi.h                      |   2 +
 sound/pci/hda/patch_hdmi.c                    |  19 ++-
 sound/soc/codecs/hdac_hda.c                   | 114 ++++++++++++++++--
 sound/soc/codecs/hdac_hda.h                   |  13 +-
 sound/soc/intel/boards/Makefile               |  10 +-
 sound/soc/intel/boards/bxt_da7219_max98357a.c |  11 ++
 sound/soc/intel/boards/bxt_rt298.c            |  11 ++
 sound/soc/intel/boards/glk_rt5682_max98357a.c |  11 ++
 sound/soc/intel/boards/hda_dsp_common.c       |  85 +++++++++++++
 sound/soc/intel/boards/hda_dsp_common.h       |  32 +++++
 sound/soc/intel/boards/skl_hda_dsp_common.c   |   6 +
 sound/soc/intel/boards/skl_hda_dsp_common.h   |  27 ++++-
 sound/soc/intel/boards/skl_hda_dsp_generic.c  |   1 +
 sound/soc/intel/boards/sof_rt5682.c           |  11 ++
 sound/soc/sof/intel/Kconfig                   |  10 ++
 sound/soc/sof/intel/hda-codec.c               |  22 +++-
 sound/soc/sof/intel/hda.c                     |   6 +
 sound/soc/sof/intel/hda.h                     |   6 +-
 19 files changed, 367 insertions(+), 31 deletions(-)
 create mode 100644 sound/soc/intel/boards/hda_dsp_common.c
 create mode 100644 sound/soc/intel/boards/hda_dsp_common.h
Signature · 6 lines
2.17.1

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel