Skip to content

drivers: add new variants of devm_platform_ioremap_resource()

Bartosz Golaszewski linux-doc linux-gpio lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/28 patches 5 repliesIn review
  2. v3 posting 1/28 patches 7 repliesSuperseded
  3. v25 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v19 patches3 repliesSuperseded

Changes in v3 from the cover letter

- don't call platform_get_resource() as an argument of devm_ioremap_resource(), it actually decreases readability
- add devm_platform_ioremap_resource_byname() as another variant

Patches in v3 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8Documentation: devres: add missing entry for devm_platform_ioremap_resource()Documentation/driver-api/driver-model/devres.rst+1 -00 replies
2/8lib: devres: prepare devm_ioremap_resource() for more variantslib/devres.c+27 -200 replies
3/8lib: devres: provide devm_ioremap_resource_wc()Documentation/driver-api/driver-model/devres.rst include/linux/device.h lib/devres.c+18 -00 replies
4/8drivers: platform: provide devm_platform_ioremap_resource_wc()Documentation/driver-api/driver-model/devres.rst drivers/base/platform.c include/linux/platform_device.h+22 -10 replies
5/8misc: sram: use devm_platform_ioremap_resource_wc()drivers/misc/sram.c+8 -200 replies
6/8drivers: provide devm_platform_ioremap_resource_byname()Documentation/driver-api/driver-model/devres.rst drivers/base/platform.c include/linux/platform_device.h+24 -00 replies
7/8gpio: mvebu: use devm_platform_ioremap_resource_byname()drivers/gpio/gpio-mvebu.c+7 -121 reply
8/8gpio: tegra186: use devm_platform_ioremap_resource_byname()drivers/gpio/gpio-tegra186.c+1 -31 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchArnd BergmannLinus Walleij
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b A-b
8/8R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [RESEND PATCH v3 0/8] drivers: add new variants of devm_platform_ioremap_resource()

From: Bartosz Golaszewski <[email protected]>

Note: resending with Arnd's review tags and rebased on top of char-misc-next

The new devm_platform_ioremap_resource() helper has now been widely adopted and used in many drivers. Users of the write-combined ioremap() variants could benefit from the same code shrinkage. This series provides a write-combined version of devm_platform_ioremap_resource() and uses it in a relevant driver with the assumption that - just like was the case previously - a coccinelle script will be developed to ease the transition for others.

There are also users of platform_get_resource_byname() who call devm_ioremap_resource() next, so provide another variant that they can use together with two examples.

v1 -> v2:
- dropped everything related to nocache ioremap as this is going away

v2 -> v3:
- don't call platform_get_resource() as an argument of devm_ioremap_resource(), it actually decreases readability
- add devm_platform_ioremap_resource_byname() as another variant

Bartosz Golaszewski (8):
Documentation: devres: add missing entry for
devm_platform_ioremap_resource()
lib: devres: prepare devm_ioremap_resource() for more variants
lib: devres: provide devm_ioremap_resource_wc()
drivers: platform: provide devm_platform_ioremap_resource_wc()
misc: sram: use devm_platform_ioremap_resource_wc()
drivers: provide devm_platform_ioremap_resource_byname()
gpio: mvebu: use devm_platform_ioremap_resource_byname()
gpio: tegra186: use devm_platform_ioremap_resource_byname()

 .../driver-api/driver-model/devres.rst        |  4 ++
 drivers/base/platform.c                       | 39 +++++++++++-
 drivers/gpio/gpio-mvebu.c                     | 19 +++---
 drivers/gpio/gpio-tegra186.c                  |  4 +-
 drivers/misc/sram.c                           | 28 +++------
 include/linux/device.h                        |  2 +
 include/linux/platform_device.h               |  6 ++
 lib/devres.c                                  | 62 +++++++++++++------
 8 files changed, 108 insertions(+), 56 deletions(-)
Signature · 1 line
2.23.0