Skip to content

Test suite tidiness

Ben Boeckel keyrings 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 0 repliesNew
  2. v113 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13tests/toolbox: detect endianness with PIE executablestests/toolbox.inc.sh+2 -20 replies
2/13tests: fix some typos in marker linestests/keyctl/clear/valid/runtest.sh+1 -10 replies
3/13tests: remove some trailing whitespacetests/keyctl/dh_compute/bad-args/runtest.sh tests/keyctl/pupdate/userupdate/runtest.sh tests/keyctl/unlink/all/runtest.sh +2 more+16 -160 replies
4/13keyctl: unify spelling of "unparsable"keyctl.c+3 -30 replies
5/13tests: fix typos in test commentstests/keyctl/add/bad-args/runtest.sh tests/keyctl/link/recursion/runtest.sh tests/keyctl/newring/bad-args/runtest.sh +6 more+11 -110 replies
6/13tests/revoke: test key revokation in the revoke teststests/keyctl/revoke/valid/runtest.sh tests/keyctl/timeout/valid/runtest.sh+20 -170 replies
7/13tests/timeout: test actions on an expired keyring as welltests/keyctl/timeout/valid/runtest.sh+15 -00 replies
8/13tests/instantiating: test the unlinked keyidtests/keyctl/instantiating/bad-args/runtest.sh+3 -30 replies
9/13test/instantiating: test bad arguments for `keyctl reject`tests/keyctl/instantiating/bad-args/runtest.sh tests/toolbox.inc.sh+36 -00 replies
10/13tests/reading: fix test commenttests/keyctl/reading/valid/runtest.sh+1 -10 replies
11/13tests/reading: remove revokation testtests/keyctl/reading/valid/runtest.sh+0 -60 replies
11/13tests/readming: remove revokation testtests/keyctl/reading/valid/runtest.sh+0 -60 replies
12/13tests/search: test searching with a mismatched typetests/keyctl/search/valid/runtest.sh+5 -00 replies
13/13tests/search: test a found key without search permissionstests/keyctl/search/valid/runtest.sh+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/13] Test suite tidiness

A collection of minor patches to the test suite I discovered while porting to the Rust bindings I've been working on:

https://github.com/mathstuf/rust-keyutils
https://github.com/mathstuf/rust-keyutils/pull/34 (for the porting of the test suite)

Mostly typos, relocating some tests to what seems to be more sensible location, fixing some copy/pasta, and adding some missed test cases. The patches were developed against master, but have been rebased here against next to make it easier to add to it. If that is incorrect, I can rebase onto master and respin.

Note that I'm sending these for review now, but I'll be on vacation for a few weeks. Feel free to leave review comments; I'll act on them once I return.

Thanks,

--Ben

Ben Boeckel (13):
tests/toolbox: detect endianness with PIE executables
tests: fix some typos in marker lines
tests: remove some trailing whitespace
keyctl: unify spelling of "unparsable"
tests: fix typos in test comments
tests/revoke: test key revokation in the revoke tests tests/timeout: test actions on an expired keyring as well tests/instantiating: test the unlinked keyid test/instantiating: test bad arguments for keyctl reject tests/reading: fix test comment
tests/reading: remove revokation test tests/search: test searching with a mismatched type tests/search: test a found key without search permissions

 keyctl.c                                      |  6 ++--
 tests/keyctl/add/bad-args/runtest.sh          |  2 +-
 tests/keyctl/clear/valid/runtest.sh           |  2 +-
 tests/keyctl/dh_compute/bad-args/runtest.sh   |  2 +-
 .../keyctl/instantiating/bad-args/runtest.sh  | 20 ++++++++++--
 tests/keyctl/link/recursion/runtest.sh        |  2 +-
 tests/keyctl/newring/bad-args/runtest.sh      |  2 +-
 tests/keyctl/padd/bad-args/runtest.sh         |  2 +-
 tests/keyctl/pupdate/userupdate/runtest.sh    | 10 +++---
 tests/keyctl/reading/valid/runtest.sh         |  8 +----
 tests/keyctl/requesting/bad-args/runtest.sh   |  2 +-
 tests/keyctl/requesting/piped/runtest.sh      |  4 +--
 tests/keyctl/requesting/valid/runtest.sh      |  4 +--
 tests/keyctl/revoke/valid/runtest.sh          | 20 ++++++++++++
 tests/keyctl/search/bad-args/runtest.sh       |  2 +-
 tests/keyctl/search/valid/runtest.sh          | 13 +++++---
 tests/keyctl/session/bad-args/runtest.sh      |  2 +-
 tests/keyctl/timeout/valid/runtest.sh         | 32 +++++++++----------
 tests/keyctl/unlink/all/runtest.sh            |  2 +-
 tests/keyctl/unlink/valid/runtest.sh          |  4 +--
 tests/keyctl/update/userupdate/runtest.sh     | 14 ++++----
 tests/toolbox.inc.sh                          | 26 +++++++++++++--
 22 files changed, 117 insertions(+), 64 deletions(-)
Signature · 1 line
2.21.0