Skip to content

RFC DC3CO Support for TGL

Anshuman Gupta intel-gfx 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/i915/tgl: Add DC3CO required register and bitsdrivers/gpu/drm/i915/i915_reg.h+8 -00 replies
2/7drm/i915/tgl: Add DC3CO mask to allowed_dc_mask and gen9_dc_maskdrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/i915_params.c+23 -90 replies
3/7drm/i915/tgl: Enable DC3CO state in "DC Off" power welldrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h drivers/gpu/drm/i915/i915_drv.h+89 -200 replies
4/7drm/i915/tgl: Add helper function for DC3CO exitline.drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h +3 more+91 -10 replies
5/7drm/i915/tgl: DC3CO PSR2 helperdrivers/gpu/drm/i915/display/intel_psr.c drivers/gpu/drm/i915/display/intel_psr.h+45 -00 replies
6/7drm/i915/tgl: switch between dc3co and dc5 based on display idlenessdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h +3 more+87 -00 replies
7/7drm/i915/tgl: Add DC3CO counter in i915_dmc_infodrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_reg.h+8 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/7] DC3CO Support for TGL

This is a new design proposal for DC3CO feature after disscussing it with Ville and Imre.

This design uses a API tgl_set_target_dc_state() API to switch between DC3CO and DC5 by using "DC off" power well. Another major change in this design using page flip frontbuffer flush call to allow DC3CO.

As part of DC3CO feature, it needs to configure and enable TRANS_EXITLINE register which only needs to change when transcoder/port is not enabled. It requires to configure and enable it in full modeset sequence. Which requires to force the modeset at only at system bootup, with only eDP panel. (when system boots with only eDP panel there will not be real
modeset). I observed sometimes hang while early bootup, which
seems side effect of forcing a modeset at bootup. I am working to fix it.

Tagging this as RFC series, i need feedback, suggestion and ACK to this new design.

Anshuman Gupta (7):
drm/i915/tgl: Add DC3CO required register and bits drm/i915/tgl: Add DC3CO mask to allowed_dc_mask and gen9_dc_mask drm/i915/tgl: Enable DC3CO state in "DC Off" power well drm/i915/tgl: Add helper function for DC3CO exitline. drm/i915/tgl: DC3CO PSR2 helper
drm/i915/tgl: switch between dc3co and dc5 based on display idleness drm/i915/tgl: Add DC3CO counter in i915_dmc_info

 drivers/gpu/drm/i915/display/intel_display.c  |   4 +
 .../drm/i915/display/intel_display_power.c    | 289 ++++++++++++++++--
 .../drm/i915/display/intel_display_power.h    |  14 +
 .../gpu/drm/i915/display/intel_frontbuffer.c  |   1 +
 drivers/gpu/drm/i915/display/intel_psr.c      |  44 +++
 drivers/gpu/drm/i915/display/intel_psr.h      |   2 +
 drivers/gpu/drm/i915/i915_debugfs.c           |   6 +
 drivers/gpu/drm/i915/i915_drv.h               |   4 +
 drivers/gpu/drm/i915/i915_params.c            |   3 +-
 drivers/gpu/drm/i915/i915_reg.h               |  10 +
 drivers/gpu/drm/i915/intel_pm.c               |   2 +-
 drivers/gpu/drm/i915/intel_pm.h               |   2 +
 12 files changed, 351 insertions(+), 30 deletions(-)
Signature · 6 lines
2.21.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx