Skip to content

RFC crypto/luks: encryption key managment using amend interface

Maxim Levitsky qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 40 repliesIn review
  2. v110 patches 19 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11qcrypto: add suport for amend optionscrypto/block.c crypto/blockpriv.h include/crypto/block.h+61 -02 replies
2/11qcrypto-luks: extend the create options for upcoming encryption key managementblock/crypto.c block/crypto.h block/qcow2.c +3 more+115 -48 replies
3/11qcrypto-luks: implement the encryption key managementcrypto/block-luks.c+354 -20 replies
4/11block: amend: add 'force' optionblock.c block/qcow2.c include/block/block.h +4 more+20 -50 replies
5/11block/crypto: implement the encryption key managementblock/crypto.c+115 -36 replies
6/11qcow2: implement crypto amend optionsblock/qcow2.c+62 -150 replies
7/11block: add x-blockdev-amend qmp commandblock/Makefile.objs block/amend.c include/block/block_int.h +2 more+163 -87 replies
8/11block/crypto: implement blockdev-amendblock/crypto.c qapi/block-core.json+71 -212 replies
9/11block/qcow2: implement blockdev-amendblock/qcow2.c qapi/block-core.json+75 -24 replies
10/11iotests: filter few more luks specific create optionstests/qemu-iotests/087.out tests/qemu-iotests/134.out tests/qemu-iotests/158.out +4 more+15 -130 replies
11/11iotests : add tests for encryption key managementtests/qemu-iotests/300 tests/qemu-iotests/300.out tests/qemu-iotests/301 +6 more+955 -02 replies

Reviews trailers per patch

3 of 11 patches have a Reviewed-by or Acked-by.

PatchDaniel P. Berrangé
1/11R-b
2/11
3/11
4/11R-b
5/11
6/11
7/11
8/11R-b
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/11] RFC crypto/luks: encryption key managment using amend interface

This patch series is continuation of my work to add encryption key managment to luks/qcow2 with luks.

This is second version of this patch set.
The changes are mostly addressing the review feedback, plus I tested (and fixed sadly) the somewhat ugly code that allows to still write share a raw luks device, while preveting the key managment from happening in this case, as it is unsafe.
I added a new iotest dedicated to that as well.

Best regards,
Maxim Levitsky

Maxim Levitsky (11):
qcrypto: add suport for amend options
qcrypto-luks: extend the create options for upcoming encryption key
management
qcrypto-luks: implement the encryption key management
block: amend: add 'force' option
block/crypto: implement the encryption key management
qcow2: implement crypto amend options
block: add x-blockdev-amend qmp command
block/crypto: implement blockdev-amend
block/qcow2: implement blockdev-amend
iotests: filter few more luks specific create options iotests : add tests for encryption key management

 block.c                          |   4 +-
 block/Makefile.objs              |   2 +-
 block/amend.c                    | 116 ++++++++++
 block/crypto.c                   | 167 +++++++++++++-
 block/crypto.h                   |  16 ++
 block/qcow2.c                    | 151 ++++++++++--
 crypto/block-luks.c              | 382 ++++++++++++++++++++++++++++++-
 crypto/block.c                   |  31 +++
 crypto/blockpriv.h               |   8 +
 include/block/block.h            |   1 +
 include/block/block_int.h        |  22 +-
 include/crypto/block.h           |  22 ++
 qapi/block-core.json             |  39 +++-
 qapi/crypto.json                 |  19 ++
 qapi/job.json                    |   4 +-
 qemu-img-cmds.hx                 |   4 +-
 qemu-img.c                       |   8 +-
 qemu-img.texi                    |   6 +-
 tests/qemu-iotests/082.out       |  54 +++++
 tests/qemu-iotests/087.out       |   6 +-
 tests/qemu-iotests/134.out       |   2 +-
 tests/qemu-iotests/158.out       |   4 +-
 tests/qemu-iotests/188.out       |   2 +-
 tests/qemu-iotests/189.out       |   4 +-
 tests/qemu-iotests/198.out       |   4 +-
 tests/qemu-iotests/300           | 202 ++++++++++++++++
 tests/qemu-iotests/300.out       |  98 ++++++++
 tests/qemu-iotests/301           |  90 ++++++++
 tests/qemu-iotests/301.out       |  30 +++
 tests/qemu-iotests/302           | 252 ++++++++++++++++++++
 tests/qemu-iotests/302.out       |  18 ++
 tests/qemu-iotests/303           | 228 ++++++++++++++++++
 tests/qemu-iotests/303.out       |  28 +++
 tests/qemu-iotests/common.filter |   6 +-
 tests/qemu-iotests/group         |   9 +
 35 files changed, 1986 insertions(+), 53 deletions(-)
 create mode 100644 block/amend.c
 create mode 100755 tests/qemu-iotests/300
 create mode 100644 tests/qemu-iotests/300.out
 create mode 100755 tests/qemu-iotests/301
 create mode 100644 tests/qemu-iotests/301.out
 create mode 100644 tests/qemu-iotests/302
 create mode 100644 tests/qemu-iotests/302.out
 create mode 100644 tests/qemu-iotests/303
 create mode 100644 tests/qemu-iotests/303.out
Signature · 1 line
2.17.2