Skip to content

mptcp: token api refactoring/cleanup

Florian Westphal mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mptcp: token: remove token_initnet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/token.c+6 -130 replies
2/2mptcp: token: add mptcp prefixes to functionsnet/mptcp/pm.c net/mptcp/protocol.c net/mptcp/protocol.h +2 more+254 -3080 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [PATCH MPTCP 0/2] mptcp: token api refactoring/cleanup

I tried to fold the earlier 'RFC v2' in a way so that it allows easy squashing.

Patch #1 is the only one where this is painless.
For all others, things are not easy because conflicts exist all over the place.

So I see two ways forward:
1. I rebase this myself and offer a pull request for the resulting series
2. Only squash the first patch and keep the rest as extra patch.

I suggest we go with #2. The export tree already has a few patches that need to be squashed anyway before sending a formal series.

Also, the export branch is currently not bisectable, I get build errors mid-series.

I don't think this is a problem for now, I think it makes sense to not squash the larger patches for the time being.

Once another patch series is to be submitted to netdev, the export branch can be renamed/archived and a reorganisation can be done at that point (and the result diff'd versus the old export branch to make sure there is no difference in resulting code).