Skip to content

vpc: Return 0 from vpc_co_create() on success

Max Reitz qemu-devel 1 version Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest5 patches 1 replyApplied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5vpc: Return 0 from vpc_co_create() on successblock/vpc.c+2 -10 replies
2/5iotests: Add supported protocols to execute_test()tests/qemu-iotests/iotests.py+3 -10 replies
3/5iotests: Restrict file Python tests to filetests/qemu-iotests/030 tests/qemu-iotests/040 tests/qemu-iotests/041 +23 more+52 -260 replies
4/5iotests: Restrict nbd Python tests to nbdtests/qemu-iotests/147 tests/qemu-iotests/205+4 -40 replies
5/5iotests: Test blockdev-create for vpctests/qemu-iotests/266 tests/qemu-iotests/266.out tests/qemu-iotests/group+291 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/5] vpc: Return 0 from vpc_co_create() on success

(v2 for “block: Let blockdev-create return 0 on success”)

Jobs are expected to return 0 on success, so this extends to .bdrv_co_create(). After some inspection, it turns out that vpc is the only block driver that may return a positive value instead (to indicate success). Fix that.

Without this patch, blockdev-create is likely to fail for VPC images. Hence patch 5.

John indicated his preference for me to use iotests.script_main(). I did that; but I still wanted to retain some form of verify_protocol(). Patch 2 adds @supported_protocols to execute_test() (and thus to iotests.script_main() and iotests.main()). Then I noticed we should probably make all Python tests (that use either script_main() or main()) pass something for that parameter, because it’s a bit silly to run all Python tests for raw when you just want to run the nbd tests (which are five or so). Enter patches 3 and 4.

(There are two Python tests (093 and 136) which I didn’t change to pass supported_protocols, because they use null-{co,aio} as their protocol. As these are not actually testee protocols for the iotests, I decided to just keep running these tests for any protocol.)

For completeness’ sake[1]:

git-backport-diff against v1:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/5:[down] 'vpc: Return 0 from vpc_co_create() on success' 002/5:[down] 'iotests: Add supported protocols to execute_test()' 003/5:[down] 'iotests: Restrict file Python tests to file' 004/5:[down] 'iotests: Restrict nbd Python tests to nbd' 005/5:[0204] [FC] 'iotests: Test blockdev-create for vpc'

[1]
Please vote on the correct spelling:
(A) “For completeness sake”
(B) “For completeness’ sake”
(C) “For completeness’s sake”

By participating, you become eligible to receive mention in the git log.

To give you mention, we need your full name and email address. Therefore, please cast your vote by replying to this mail as follows:

Quoted 3 lines

I vote for ${letter}${reason:=.}

Reviewed-by $name <$email_address>

(Set the “letter” variable to be any of A, B, or C; “reason” to be a justification (optional; should be prefixed by “, because ” and end with a full stop); “name” to be your name; and “email_address” to be your email address.)

Thank you for doing your part in saving democracy!

Max Reitz (5):
vpc: Return 0 from vpc_co_create() on success
iotests: Add supported protocols to execute_test()
iotests: Restrict file Python tests to file
iotests: Restrict nbd Python tests to nbd
iotests: Test blockdev-create for vpc

 block/vpc.c                   |   3 +-
 tests/qemu-iotests/030        |   3 +-
 tests/qemu-iotests/040        |   3 +-
 tests/qemu-iotests/041        |   3 +-
 tests/qemu-iotests/044        |   3 +-
 tests/qemu-iotests/045        |   3 +-
 tests/qemu-iotests/055        |   3 +-
 tests/qemu-iotests/056        |   3 +-
 tests/qemu-iotests/057        |   3 +-
 tests/qemu-iotests/065        |   3 +-
 tests/qemu-iotests/096        |   3 +-
 tests/qemu-iotests/118        |   3 +-
 tests/qemu-iotests/124        |   3 +-
 tests/qemu-iotests/129        |   3 +-
 tests/qemu-iotests/132        |   3 +-
 tests/qemu-iotests/139        |   3 +-
 tests/qemu-iotests/147        |   5 +-
 tests/qemu-iotests/148        |   3 +-
 tests/qemu-iotests/151        |   3 +-
 tests/qemu-iotests/152        |   3 +-
 tests/qemu-iotests/155        |   3 +-
 tests/qemu-iotests/163        |   3 +-
 tests/qemu-iotests/165        |   3 +-
 tests/qemu-iotests/169        |   3 +-
 tests/qemu-iotests/196        |   3 +-
 tests/qemu-iotests/199        |   3 +-
 tests/qemu-iotests/205        |   3 +-
 tests/qemu-iotests/245        |   3 +-
 tests/qemu-iotests/257        |   3 +-
 tests/qemu-iotests/266        | 153 ++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/266.out    | 137 ++++++++++++++++++++++++++++++
 tests/qemu-iotests/group      |   1 +
 tests/qemu-iotests/iotests.py |   4 +-
 33 files changed, 352 insertions(+), 32 deletions(-)
 create mode 100755 tests/qemu-iotests/266
 create mode 100644 tests/qemu-iotests/266.out
Signature · 1 line
2.21.0