Skip to content

bnxt patchset to improve rte flow support

Ajit Khaparde dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest20 patches 4 repliesIn review
  2. v117 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20net/bnxt: return standard error codes for HWRM commanddrivers/net/bnxt/bnxt_hwrm.c+14 -20 replies
2/20net/bnxt: refactor code to allow dynamic creation of VNICdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_flow.c +4 more+78 -560 replies
3/20net/bnxt: allow flow creation when RSS is enableddrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_flow.c +1 more+149 -330 replies
4/20net/bnxt: add support to create SMAC and inner DMAC filtersdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_filter.h +4 more+160 -290 replies
5/20net/bnxt: add support for RSS actiondrivers/net/bnxt/bnxt_filter.h drivers/net/bnxt/bnxt_flow.c drivers/net/bnxt/bnxt_hwrm.c +2 more+337 -580 replies
6/20net/bnxt: parse priority attribute for flow creationdrivers/net/bnxt/bnxt_filter.h drivers/net/bnxt/bnxt_flow.c+12 -140 replies
7/20net/bnxt: delete and flush L2 filters cleanlydrivers/net/bnxt/bnxt_filter.c drivers/net/bnxt/bnxt_flow.c drivers/net/bnxt/bnxt_hwrm.c+75 -340 replies
8/20net/bnxt: cleanup vnic after flow validatedrivers/net/bnxt/bnxt_flow.c drivers/net/bnxt/bnxt_hwrm.c drivers/net/bnxt/bnxt_hwrm.h+73 -470 replies
9/20net/bnxt: fix an issue in setting default MAC addressdrivers/net/bnxt/bnxt_ethdev.c+5 -20 replies
10/20net/bnxt: allow only unicast MAC address filter creationdrivers/net/bnxt/bnxt_flow.c+16 -00 replies
11/20net/bnxt: properly handle ring cleanup in case of errordrivers/net/bnxt/bnxt_ring.c+37 -00 replies
12/20net/bnxt: check device is started before flow creationdrivers/net/bnxt/bnxt_flow.c+9 -00 replies
13/20net/bnxt: check for invalid VNIC ID in vnic tpa cfgdrivers/net/bnxt/bnxt_hwrm.c+5 -00 replies
14/20net/bnxt: validate RSS hash key lengthdrivers/net/bnxt/bnxt_ethdev.c+12 -60 replies
15/20net/bnxt: handle cleanup if flow creation failsdrivers/net/bnxt/bnxt_flow.c+61 -50 replies
16/20net/bnxt: synchronize between flow related functionsdrivers/net/bnxt/bnxt.h drivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_flow.c+69 -90 replies
17/20net/bnxt: drop untagged frames when specifieddrivers/net/bnxt/bnxt_filter.h drivers/net/bnxt/bnxt_flow.c+61 -61 reply
18/20net/bnxt: fix VLAN filtering code pathdrivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_filter.h drivers/net/bnxt/bnxt_hwrm.c+128 -350 replies
19/20net/bnxt: fix multicast filter programmingdrivers/net/bnxt/bnxt_ethdev.c drivers/net/bnxt/bnxt_hwrm.c+8 -70 replies
20/20net/bnxt: handle flow flush handlingdrivers/net/bnxt/bnxt_flow.c+32 -311 reply

Reviews trailers per patch

19 of 20 patches have a Reviewed-by or Acked-by.

PatchRahul GuptaVenkat DuvvuruSomnath KoturAjit KhapardeSantoshkumar Karanappa RastapurLance RichardsonKalesh Anakkur Purayil
1/20
2/20R-b R-b
3/20R-b R-b
4/20R-b R-b
5/20R-b R-b
6/20R-b R-b
7/20R-b R-b
8/20R-b R-b
9/20R-b R-b
10/20R-b R-b
11/20R-b R-b R-b
12/20R-b R-b
13/20R-b R-b
14/20R-b R-b R-b R-b R-b
15/20R-b R-b R-b
16/20R-b
17/20R-b R-b R-b
18/20R-b
19/20R-b
20/20R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v2 thread

Cover letter [dpdk-dev] [PATCH v2 00/20] bnxt patchset to improve rte flow support

Among other changes, this patchset adds support to:
- create filters with RSS action.
- create source MAC filters.
- use user provided priority to place rule appropriately in HW.

This patch has been rebased to dpdk-next-net commit 8587a8b9eddefa39e4ceac7e9385efcc5e73307c

Please apply.

Ajit Khaparde (13):
net/bnxt: return standard error codes for HWRM command net/bnxt: refactor code to allow dynamic creation of VNIC net/bnxt: allow flow creation when RSS is enabled net/bnxt: add support to create SMAC and inner DMAC filters net/bnxt: add support for RSS action
net/bnxt: parse priority attribute for flow creation net/bnxt: delete and flush L2 filters cleanly net/bnxt: cleanup vnic after flow validate net/bnxt: allow only unicast MAC address filter creation net/bnxt: check device is started before flow creation net/bnxt: handle cleanup if flow creation fails net/bnxt: drop untagged frames when specified net/bnxt: handle flow flush handling

Kalesh AP (2):
net/bnxt: fix an issue in setting default MAC address net/bnxt: fix multicast filter programming

Rahul Gupta (1):
net/bnxt: properly handle ring cleanup in case of error

Somnath Kotur (1):
net/bnxt: check for invalid VNIC ID in vnic tpa cfg

Venkat Duvvuru (3):
net/bnxt: validate RSS hash key length net/bnxt: synchronize between flow related functions net/bnxt: fix VLAN filtering code path

 drivers/net/bnxt/bnxt.h        |  12 +
 drivers/net/bnxt/bnxt_ethdev.c | 254 ++++++---
 drivers/net/bnxt/bnxt_filter.c |  18 +-
 drivers/net/bnxt/bnxt_filter.h |  18 +
 drivers/net/bnxt/bnxt_flow.c   | 904 ++++++++++++++++++++++++++++-----
 drivers/net/bnxt/bnxt_hwrm.c   | 190 +++++--
 drivers/net/bnxt/bnxt_hwrm.h   |   7 +-
 drivers/net/bnxt/bnxt_ring.c   |  37 ++
 drivers/net/bnxt/bnxt_rxq.c    |  29 +-
 drivers/net/bnxt/bnxt_vnic.c   |  38 +-
 drivers/net/bnxt/bnxt_vnic.h   |   6 +
 11 files changed, 1240 insertions(+), 273 deletions(-)
Signature · 1 line
2.20.1 (Apple Git-117)