Skip to content

brcmfmac: keep wiphy during PCIe driver lifetime

Rafał Miłecki linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3brcmfmac: move "cfg80211_ops" pointer to another structdrivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +1 more+7 -53 replies
2/3brcmfmac: split brcmf_attach() and brcmf_detach() functionsdrivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +2 more+80 -191 reply
3/3brcmfmac: don't realloc wiphy during PCIe resetdrivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c+4 -41 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchArend van Spriel
1/3
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] brcmfmac: keep wiphy during PCIe driver lifetime

From: Rafał Miłecki <[email protected]>

Driver's main init/attach function brcmf_attach() was handling both:
wiphy allocation and driver initialization. It meant getting a new wiphy on every init (initial, resume, error recovery).

For supplicants/authenticators and Linux users it's move convenient to have the same wiphy over driver's lifetime. It allows e.g. automatic recovery after a firmware crash.

This patchset was tested on BCM4366 (PCIe) and BCM43430 (SDIO).

Right now only PCIe makes use of keeping the same wiphy. I got RPi Zero W so I'm planning to add firmware crash recovery & keep wiphy for SDIO in the future.

Rafał Miłecki (3):
brcmfmac: move "cfg80211_ops" pointer to another struct
brcmfmac: split brcmf_attach() and brcmf_detach() functions
brcmfmac: don't realloc wiphy during PCIe reset

 .../broadcom/brcm80211/brcmfmac/bus.h         |  4 +-
 .../broadcom/brcm80211/brcmfmac/cfg80211.c    |  1 -
 .../broadcom/brcm80211/brcmfmac/cfg80211.h    |  1 -
 .../broadcom/brcm80211/brcmfmac/core.c        | 42 ++++++++++++++-----
 .../broadcom/brcm80211/brcmfmac/core.h        |  1 +
 .../broadcom/brcm80211/brcmfmac/pcie.c        | 13 +++++-
 .../broadcom/brcm80211/brcmfmac/sdio.c        | 15 +++++--
 .../broadcom/brcm80211/brcmfmac/usb.c         | 34 ++++++++++++---
 8 files changed, 87 insertions(+), 24 deletions(-)
Signature · 1 line
2.21.0