Skip to content

Make the core libqtest library independe from global_qtest

Thomas Huth qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 13 repliesIn review
  2. v16 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Do not add parameter to qvirtio_wait_config_isr(), but push the logic into virtio-mmio.c and virtio-pci.c instead since we have access to the test state here (as suggested by Laurent).

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6tests/migration: Do not use functions anymore that rely on global_qtesttests/migration-test.c+3 -31 reply
2/6tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtesttests/libqos/e1000e.c+11 -51 reply
3/6tests/libqos: Replace clock_step with qtest_clock_step in virtio codetests/libqos/virtio-mmio.c tests/libqos/virtio-pci.c tests/libqos/virtio.c +2 more+37 -202 replies
4/6tests: Remove unnecessary global_qtest referencestests/ahci-test.c tests/bios-tables-test.c tests/ivshmem-test.c +1 more+0 -62 replies
5/6tests/libqtest: Move global_test wrapper function into a separate headerMAINTAINERS tests/libqtest-single.h tests/libqtest.c +1 more+313 -2984 replies
6/6tests/libqtest: Use libqtest-single.h in tests that require global_qtesttests/cpu-plug-test.c tests/display-vga-test.c tests/e1000e-test.c +29 more+33 -362 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchLaurent VivierDr. David Alan GilbertEric BlakeStefan Hajnoczi
1/6R-b R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b R-b
5/6R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/6] Make the core libqtest library independe from global_qtest

global_qtest and the related wrapper functions often caused trouble in the past - if they are used somewhere in the libqtest or libqos library code, it's hard to write tests that properly track multiple test states (like migration tests).

This patch series finally gets rid of the remaining global_qtest dependencies in the core libqtest code. The first patches are used to clean up some files that should not use global_qtest anymore, then the wrapper functions and the global_qtest definition get moved to a separate header file called libqtest-single.h - which then should only be used in tests that track only a single test state.

v2:
- Do not add parameter to qvirtio_wait_config_isr(), but push the logic into virtio-mmio.c and virtio-pci.c instead since we have access to the test state here (as suggested by Laurent).

Thomas Huth (6):
tests/migration: Do not use functions anymore that rely on
global_qtest
tests/libqos/e1000e: Make e1000e libqos functions independent from
global_qtest
tests/libqos: Replace clock_step with qtest_clock_step in virtio code
tests: Remove unnecessary global_qtest references tests/libqtest: Move global_test wrapper function into a separate
header
tests/libqtest: Use libqtest-single.h in tests that require
global_qtest

 MAINTAINERS                   |   2 +-
 tests/ahci-test.c             |   1 -
 tests/bios-tables-test.c      |   1 -
 tests/cpu-plug-test.c         |   2 +-
 tests/display-vga-test.c      |   2 +-
 tests/e1000e-test.c           |   2 +-
 tests/fdc-test.c              |   2 +-
 tests/i440fx-test.c           |   2 +-
 tests/i82801b11-test.c        |   2 +-
 tests/intel-hda-test.c        |   2 +-
 tests/ioh3420-test.c          |   2 +-
 tests/ipmi-kcs-test.c         |   3 +-
 tests/ivshmem-test.c          |   3 -
 tests/libqos/e1000e.c         |  16 +-
 tests/libqos/virtio-mmio.c    |  14 +-
 tests/libqos/virtio-pci.c     |  14 +-
 tests/libqos/virtio.c         |  20 +--
 tests/libqos/virtio.h         |   6 +-
 tests/libqtest-single.h       | 315 ++++++++++++++++++++++++++++++++++
 tests/libqtest.c              |  13 --
 tests/libqtest.h              | 289 -------------------------------
 tests/m25p80-test.c           |   2 +-
 tests/migration-test.c        |   6 +-
 tests/qos-test.c              |   2 +-
 tests/rtas-test.c             |   1 -
 tests/rtc-test.c              |   2 +-
 tests/rtl8139-test.c          |   2 +-
 tests/test-arm-mptimer.c      |   2 +-
 tests/test-netfilter.c        |   2 +-
 tests/test-x86-cpuid-compat.c |   2 +-
 tests/tmp105-test.c           |   2 +-
 tests/tpm-crb-test.c          |   2 +-
 tests/tpm-tests.c             |   2 +-
 tests/tpm-tis-test.c          |   2 +-
 tests/usb-hcd-ohci-test.c     |   2 +-
 tests/usb-hcd-uhci-test.c     |   2 +-
 tests/usb-hcd-xhci-test.c     |   2 +-
 tests/vhost-user-test.c       |   2 +-
 tests/virtio-blk-test.c       |   5 +-
 tests/virtio-ccw-test.c       |   2 +-
 tests/virtio-net-test.c       |   2 +-
 tests/virtio-scsi-test.c      |   2 +-
 tests/virtio-serial-test.c    |   2 +-
 43 files changed, 396 insertions(+), 367 deletions(-)
 create mode 100644 tests/libqtest-single.h
Signature · 1 line
2.18.1