Skip to content

RFC sched and membarrier probe_kernel_address fixes

Mathieu Desnoyers lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Fix: sched: task_rcu_dereference: check probe_kernel_address return valuekernel/exit.c+2 -14 replies
2/3Fix: sched/membarrier: READ_ONCE p->mm in membarrier_global_expeditedkernel/sched/membarrier.c+9 -52 replies
3/3Fix: sched/membarrier: use probe_kernel_address to read mm->membarrier_statekernel/sched/membarrier.c+28 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/3] sched and membarrier probe_kernel_address fixes

There is an ongoing discussion [1] about the need to fix use of probe_kernel_address in task_rcu_deference (or provide additional existence guarantees), and add missing READ_ONCE and probe_kernel_address when reading other cpu runqueue's mm->membarrier_state.

This patch set simply adds the missing probe_kernel_address checks and use, aiming to be easily backported to stable kernels. Changing the existence guarantees of sighand and mm objects is expected to deprecate those changes for future kernels, but it's unclear whether those more intrusive changes will be acceptable for stable kernel branches.

Thanks,

Mathieu

[1] https://lore.kernel.org/r/[email protected]

Mathieu Desnoyers (3):
Fix: sched: task_rcu_dereference: check probe_kernel_address return
value
Fix: sched/membarrier: READ_ONCE p->mm in membarrier_global_expedited
Fix: sched/membarrier: use probe_kernel_address to read

    mm->membarrier_state
 kernel/exit.c             |  3 ++-
 kernel/sched/membarrier.c | 27 +++++++++++++++++++++++++--
 2 files changed, 27 insertions(+), 3 deletions(-)
Signature · 1 line
2.17.1