Skip to content

nfs: Mount API conversion

Scott Mayhew linux-fsdevel linux-nfs linux-security-module lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest27 patches 3 repliesIn review
  2. v527 patches 4 repliesSuperseded
  3. v426 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v326 patches5 repliesSuperseded
v226 patches2 repliesSuperseded

Changes in v6 from the cover letter

- fixed possible derefence of error pointer in nfs4_validate_fspath() reported by Dan Carpenter
- rebased on top of v5.5-rc1

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/27saner calling conventions for nfs_fs_mount_common()fs/nfs/nfs4super.c fs/nfs/super.c+5 -220 replies
2/27nfs: stash server into struct nfs_mount_infofs/nfs/internal.h fs/nfs/nfs4super.c fs/nfs/super.c+14 -180 replies
3/27nfs: lift setting mount_info from nfs4_remote{,_referral}_mountfs/nfs/nfs4super.c+35 -320 replies
4/27nfs: fold nfs4_remote_fs_type and nfs4_remote_referral_fs_typefs/nfs/nfs4super.c+4 -220 replies
5/27nfs: don't bother setting/restoring export_path around do_nfs_root_mount()fs/nfs/nfs4super.c+0 -40 replies
6/27nfs4: fold nfs_do_root_mount/nfs_follow_remote_pathfs/nfs/nfs4super.c+37 -510 replies
7/27nfs: lift setting mount_info from nfs_xdev_mount()fs/nfs/internal.h fs/nfs/namespace.c fs/nfs/super.c+26 -370 replies
8/27nfs: stash nfs_subversion reference into nfs_mount_infofs/nfs/internal.h fs/nfs/namespace.c fs/nfs/nfs4super.c +1 more+6 -30 replies
9/27nfs: don't bother passing nfs_subversion to ->try_mount() and nfs_fs_mount_common()fs/nfs/internal.h fs/nfs/nfs4_fs.h fs/nfs/nfs4super.c +2 more+14 -210 replies
10/27nfs: merge xdev and remote file_system_typefs/nfs/internal.h fs/nfs/namespace.c fs/nfs/nfs4super.c +1 more+11 -290 replies
11/27nfs: unexport nfs_fs_mount_common()fs/nfs/internal.h fs/nfs/super.c+3 -50 replies
12/27nfs: don't pass nfs_subversion to ->create_server()fs/nfs/client.c fs/nfs/internal.h fs/nfs/nfs3_fs.h +5 more+17 -220 replies
13/27nfs: get rid of mount_info ->fill_super()fs/nfs/internal.h fs/nfs/namespace.c fs/nfs/nfs4super.c +1 more+18 -640 replies
14/27nfs_clone_sb_security(): simplify the check for server bogosityfs/nfs/super.c+1 -10 replies
15/27nfs: get rid of ->set_security()fs/nfs/internal.h fs/nfs/namespace.c fs/nfs/nfs4super.c +1 more+21 -550 replies
16/27NFS: Move mount parameterisation bits into their own filefs/nfs/Makefile fs/nfs/fs_context.c fs/nfs/internal.h +1 more+1445 -14120 replies
17/27NFS: Constify mount argument match tablesfs/nfs/fs_context.c+3 -30 replies
18/27NFS: Rename struct nfs_parsed_mount_data to struct nfs_fs_contextfs/nfs/client.c fs/nfs/fs_context.c fs/nfs/internal.h +3 more+393 -3930 replies
19/27NFS: Split nfs_parse_mount_options()fs/nfs/fs_context.c fs/nfs/internal.h+73 -560 replies
20/27NFS: Deindent nfs_fs_context_parse_option()fs/nfs/fs_context.c+367 -3720 replies
21/27NFS: Add a small buffer in nfs_fs_context to avoid string dupfs/nfs/fs_context.c fs/nfs/internal.h+48 -520 replies
22/27NFS: Do some tidying of the parsing codefs/nfs/fs_context.c fs/nfs/internal.h fs/nfs/super.c+66 -780 replies
23/27NFS: rename nfs_fs_context pointer arg in a few functionsfs/nfs/client.c fs/nfs/super.c+58 -580 replies
24/27NFS: Convert mount option parsing to use functionality from fs_parser.hfs/nfs/fs_context.c+364 -4230 replies
25/27NFS: Add fs_context support.fs/nfs/fs_context.c fs/nfs/internal.h fs/nfs/namespace.c +9 more+773 -6590 replies
26/27NFS: Additional refactoring for fs_context conversionfs/nfs/client.c fs/nfs/fs_context.c fs/nfs/fscache.c +10 more+204 -2730 replies
27/27NFS: Attach supplementary error information to fs_context.fs/nfs/fs_context.c fs/nfs/getroot.c fs/nfs/internal.h +3 more+48 -720 replies

Reviews trailers per patch

15 of 27 patches have a Reviewed-by or Acked-by.

PatchDavid Howells
1/27R-b
2/27R-b
3/27R-b
4/27R-b
5/27R-b
6/27R-b
7/27R-b
8/27R-b
9/27R-b
10/27R-b
11/27R-b
12/27R-b
13/27R-b
14/27R-b
15/27R-b
16/27
17/27
18/27
19/27
20/27
21/27
22/27
23/27
24/27
25/27
26/27
27/27

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/27] nfs: Mount API conversion

Hi Anna, Trond,

Here's a set of patches that converts NFS to use the mount API. Note that there are a lot of preliminary patches, some from David and some from Al. The final patch (the one that does the actual conversion) from the David's initial posting has been split into 5 separate patches, and the entire set has been rebased on top of v5.5-rc1.

Changes since v5:
- fixed possible derefence of error pointer in nfs4_validate_fspath() reported by Dan Carpenter
- rebased on top of v5.5-rc1
Changes since v4:
- further split the original "NFS: Add fs_context support" patch (new patch is about 25% smaller than the v4 patch)
- fixed NFSv4 referral mounts (broken in the original patch)
- fixed leak of nfs_fattr when fs_context is freed
Changes since v3:
- changed license and copyright text in fs/nfs/fs_context.c Changes since v2:
- fixed the conversion of the nconnect= option
- added '#if IS_ENABLED(CONFIG_NFS_V4)' around nfs4_parse_monolithic() to avoid unused-function warning when compiling with v4 disabled
Chagnes since v1:
- split up patch 23 into 4 separate patches

-Scott

Al Viro (15):
saner calling conventions for nfs_fs_mount_common()
nfs: stash server into struct nfs_mount_info
nfs: lift setting mount_info from nfs4_remote{,_referral}_mount
nfs: fold nfs4_remote_fs_type and nfs4_remote_referral_fs_type
nfs: don't bother setting/restoring export_path around

    do_nfs_root_mount()

nfs4: fold nfs_do_root_mount/nfs_follow_remote_path
nfs: lift setting mount_info from nfs_xdev_mount()
nfs: stash nfs_subversion reference into nfs_mount_info
nfs: don't bother passing nfs_subversion to ->try_mount() and
nfs_fs_mount_common()
nfs: merge xdev and remote file_system_type
nfs: unexport nfs_fs_mount_common()
nfs: don't pass nfs_subversion to ->create_server()
nfs: get rid of mount_info ->fill_super() nfs_clone_sb_security(): simplify the check for server bogosity
nfs: get rid of ->set_security()

David Howells (8):
NFS: Move mount parameterisation bits into their own file
NFS: Constify mount argument match tables
NFS: Rename struct nfs_parsed_mount_data to struct nfs_fs_context
NFS: Split nfs_parse_mount_options()
NFS: Deindent nfs_fs_context_parse_option()
NFS: Add a small buffer in nfs_fs_context to avoid string dup
NFS: Do some tidying of the parsing code
NFS: Add fs_context support.

Scott Mayhew (4):
NFS: rename nfs_fs_context pointer arg in a few functions
NFS: Convert mount option parsing to use functionality from
fs_parser.h
NFS: Additional refactoring for fs_context conversion
NFS: Attach supplementary error information to fs_context.

 fs/nfs/Makefile         |    2 +-
 fs/nfs/client.c         |   80 +-
 fs/nfs/fs_context.c     | 1424 +++++++++++++++++++++++++
 fs/nfs/fscache.c        |    2 +-
 fs/nfs/getroot.c        |   73 +-
 fs/nfs/internal.h       |  132 +--
 fs/nfs/namespace.c      |  146 ++-
 fs/nfs/nfs3_fs.h        |    2 +-
 fs/nfs/nfs3client.c     |    6 +-
 fs/nfs/nfs3proc.c       |    2 +-
 fs/nfs/nfs4_fs.h        |    9 +-
 fs/nfs/nfs4client.c     |   99 +-
 fs/nfs/nfs4file.c       |    1 +
 fs/nfs/nfs4namespace.c  |  292 +++---
 fs/nfs/nfs4proc.c       |    2 +-
 fs/nfs/nfs4super.c      |  257 ++---
 fs/nfs/proc.c           |    2 +-
 fs/nfs/super.c          | 2217 +++++----------------------------------
 include/linux/nfs_xdr.h |    9 +-
 19 files changed, 2287 insertions(+), 2470 deletions(-)
 create mode 100644 fs/nfs/fs_context.c
Signature · 1 line
2.17.2