Skip to content

PCI: Change to using pci_dev_is_inaccessible()

Kelsey Skunberg linux-kernel-mentees linux-pci lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2PCI: Change pci_device_is_present() to pci_dev_is_inaccessible()drivers/net/ethernet/broadcom/tg3.c drivers/net/ethernet/intel/igb/igb_main.c drivers/nvme/host/pci.c +4 more+12 -120 replies
2/2PCI: Unify pci_dev_is_disconnected() and pci_dev_is_inaccessible()drivers/pci/access.c drivers/pci/msi.c drivers/pci/pci.c +2 more+10 -153 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] PCI: Change to using pci_dev_is_inaccessible()

Patch 1: Change pci_device_is_present() name to pci_dev_is_inaccessible()
to encourage only using to learn if we should not access a device that's inaccessible. Return value will need to be reversed to reflect the name change.

Patch 2: Relies on patch 1. Unify pci_dev_is_disconnected() with
pci_dev_is_inaccessible() so there is only one function needed to learn if a device is inaccessible due to surprise removal or an error condition.

Kelsey Skunberg (2):
PCI: Change pci_device_is_present() to pci_dev_is_inaccessible()
PCI: Unify pci_dev_is_disconnected() and pci_dev_is_inaccessible()

 drivers/net/ethernet/broadcom/tg3.c       |  4 ++--
 drivers/net/ethernet/intel/igb/igb_main.c |  2 +-
 drivers/nvme/host/pci.c                   |  2 +-
 drivers/pci/access.c                      | 12 ++++++------
 drivers/pci/hotplug/acpiphp_glue.c        |  2 +-
 drivers/pci/msi.c                         |  4 ++--
 drivers/pci/pci.c                         | 12 ++++++------
 drivers/pci/pci.h                         |  5 -----
 drivers/pci/pcie/portdrv_core.c           |  2 +-
 drivers/thunderbolt/nhi.c                 |  2 +-
 include/linux/pci.h                       |  2 +-
 11 files changed, 22 insertions(+), 27 deletions(-)
Signature · 1 line
2.20.1