Skip to content

i2c: aspeed: Add H/W timeout support

Jae Hyun Yoo openbmc 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v12 patches 20 repliesSuperseded

Changes in v3 from the cover letter

- Moved 'aspeed,hw-timeout-ms' property parsing logic to make it can be done before aspeed_i2c_init_clk.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: i2c: aspeed: add hardware timeout supportDocumentation/devicetree/bindings/i2c/i2c-aspeed.txt+2 -00 replies
2/2i2c: aspeed: add slave inactive timeout supportdrivers/i2c/busses/i2c-aspeed.c+76 -62 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchTao Ren
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 dev-5.2 0/2] i2c: aspeed: Add H/W timeout support

In case of multi-master environment, if a peer master incorrectly handles a bus in the middle of a transaction, I2C hardware hangs in slave state and it can't escape from the slave state, so this commit adds slave inactive timeout support to recover the bus in the case.

By applying this change, SDA data-low and SCL clock-low timeout feature also could be enabled which was disabled previously.

Changes since v2:
- Moved 'aspeed,hw-timeout-ms' property parsing logic to make it can be done before aspeed_i2c_init_clk.

Changes since v1:
- Made it use bus auto recovery feature so that bus can recover itself automatically.

Jae Hyun Yoo (2):
dt-bindings: i2c: aspeed: add hardware timeout support
i2c: aspeed: add slave inactive timeout support

 .../devicetree/bindings/i2c/i2c-aspeed.txt    |  2 +
 drivers/i2c/busses/i2c-aspeed.c               | 82 +++++++++++++++++--
 2 files changed, 78 insertions(+), 6 deletions(-)
Signature · 1 line
2.23.0